Make power down a direct function to call without any begin

Author: M65649

src/examples/low_power/low_power.ino

@@ -69,6 +69,7 @@ void setup() {
     // In powerSave(), after the LTE modem is sleeping, we also put the
     // CPU to sleep. When the time period is over, the CPU is woken at the same
     // time as the LTE modem is woken up.
+
     LowPower.configurePeriodicPowerSave(
         PowerSaveModePeriodMultiplier::THIRTY_SECONDS, 2);
 
@@ -93,5 +94,5 @@ void loop() {
 
     // Do work ...
     Log.info("Doing work...");
-    delay(5000);
+    delay(10000);
 }

src/low_power.cpp

@@ -75,8 +75,6 @@ static volatile bool ring_line_activity = false;
 static volatile bool modem_is_in_power_save = false;
 static volatile bool pit_triggered = false;
 
-static uint32_t power_down_time = 0;
-
 static bool retrieved_period = false;
 static uint32_t period = 0;
 static uint32_t period_requested = 0;
@@ -323,10 +321,6 @@ static void powerUpPeripherals(void) {
     }
 }
 
-void LowPowerClass::configurePowerDown(const uint32_t power_down_seconds) {
-    power_down_time = power_down_seconds;
-}
-
 bool LowPowerClass::configurePeriodicPowerSave(
     const PowerSaveModePeriodMultiplier power_save_mode_period_multiplier,
     const uint8_t power_save_mode_period_value) {
@@ -438,7 +432,7 @@ void LowPowerClass::powerSave(void) {
     powerUpPeripherals();
 }
 
-void LowPowerClass::powerDown(void) {
+void LowPowerClass::powerDown(const uint32_t power_down_time_seconds) {
 
     const unsigned long start_time_ms = millis();
 
@@ -449,8 +443,10 @@ void LowPowerClass::powerDown(void) {
     enablePIT();
 
     uint32_t remaining_time_seconds =
-        period - (uint32_t)(((millis() - start_time_ms) / 1000.0f));
+        power_down_time_seconds -
+        (uint32_t)(((millis() - start_time_ms) / 1000.0f));
 
+    // TODO: There is some external interrupt causing the avr to wake
     while (remaining_time_seconds > 0) {
 
         sleep_cpu();

src/low_power.h

@@ -37,14 +37,6 @@ class LowPowerClass {
         return instance;
     }
 
-    /**
-     * @brief configures the time spent in power down for both modem and CPU.
-     *
-     * @param power_down_seconds Time the LTE modem and CPU will be powered down
-     * when calling #powerDown().
-     */
-    void configurePowerDown(const uint32_t power_down_seconds);
-
     /**
      * @brief Used to configure power save mode for the LTE modem. The total
      * power save time period for the LTE modem will be
@@ -71,12 +63,6 @@ class LowPowerClass {
         const PowerSaveModePeriodMultiplier power_save_mode_period_multiplier,
         const uint8_t power_save_mode_period_value);
 
-    /**
-     * @brief Will power down both CPU and LTE modem. All active connections on
-     * the modem will be terminated.
-     */
-    void powerDown(void);
-
     /**
      * @brief Will attempt to put the modem in power save and then power down
      * the MCU for the time configured in configurePeriodicPowerSave(). Note
@@ -86,6 +72,14 @@ class LowPowerClass {
      * sleep time.
      */
     void powerSave(void);
+
+    /**
+     * @brief Will power down both CPU and LTE modem. All active connections on
+     * the modem will be terminated.
+     *
+     * @power_down_time_seconds Seconds to remain powered down.
+     */
+    void powerDown(const uint32_t power_down_time_seconds);
 };
 
 extern LowPowerClass LowPower;

src/lte.cpp

@@ -137,6 +137,7 @@ void LteClass::begin(void) {
 }
 
 void LteClass::end(void) {
+    SequansController.unregisterCallback(CEREG_CALLBACK);
     SequansController.retryCommand(AT_COMMAND_DISCONNECT);
     SequansController.end();
 }