From 7bf16e776c90c23266fda2505d71e27fc7dfc2e2 Mon Sep 17 00:00:00 2001 From: Patrick Ellis Date: Wed, 3 Jan 2024 19:01:26 -0500 Subject: [PATCH] Add "until-found" to HTMLElement.hidden Ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/hidden#until-found This has now got support from Chrome and Firefox: https://caniuse.com/wf-hidden-until-found Will also land in Safari: https://bugs.webkit.org/show_bug.cgi?id=238266 Co-authored-by: Sage Abdullah --- baselines/dom.generated.d.ts | 2 +- baselines/ts5.5/dom.generated.d.ts | 2 +- baselines/ts5.6/dom.generated.d.ts | 2 +- baselines/ts5.9/dom.generated.d.ts | 2 +- inputfiles/overridingTypes.jsonc | 4 +--- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 199e918bf..2b32da6f2 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -15996,7 +15996,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/hidden) */ - hidden: boolean; + hidden: boolean | "until-found"; /** * The HTMLElement property **`inert`** reflects the value of the element's inert attribute. It is a boolean value that, when present, makes the browser "ignore" user input events for the element, including focus events and events from assistive technologies. The browser may also ignore page search and text selection in the element. This can be useful when building UIs such as modals where you would want to "trap" the focus inside the modal when it's visible. * diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index 6dc459faf..10fa3a275 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -15980,7 +15980,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/hidden) */ - hidden: boolean; + hidden: boolean | "until-found"; /** * The HTMLElement property **`inert`** reflects the value of the element's inert attribute. It is a boolean value that, when present, makes the browser "ignore" user input events for the element, including focus events and events from assistive technologies. The browser may also ignore page search and text selection in the element. This can be useful when building UIs such as modals where you would want to "trap" the focus inside the modal when it's visible. * diff --git a/baselines/ts5.6/dom.generated.d.ts b/baselines/ts5.6/dom.generated.d.ts index 25ca7cde7..53e50608e 100644 --- a/baselines/ts5.6/dom.generated.d.ts +++ b/baselines/ts5.6/dom.generated.d.ts @@ -15993,7 +15993,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/hidden) */ - hidden: boolean; + hidden: boolean | "until-found"; /** * The HTMLElement property **`inert`** reflects the value of the element's inert attribute. It is a boolean value that, when present, makes the browser "ignore" user input events for the element, including focus events and events from assistive technologies. The browser may also ignore page search and text selection in the element. This can be useful when building UIs such as modals where you would want to "trap" the focus inside the modal when it's visible. * diff --git a/baselines/ts5.9/dom.generated.d.ts b/baselines/ts5.9/dom.generated.d.ts index fcc76b917..f03b8e9c9 100644 --- a/baselines/ts5.9/dom.generated.d.ts +++ b/baselines/ts5.9/dom.generated.d.ts @@ -15993,7 +15993,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/hidden) */ - hidden: boolean; + hidden: boolean | "until-found"; /** * The HTMLElement property **`inert`** reflects the value of the element's inert attribute. It is a boolean value that, when present, makes the browser "ignore" user input events for the element, including focus events and events from assistive technologies. The browser may also ignore page search and text selection in the element. This can be useful when building UIs such as modals where you would want to "trap" the focus inside the modal when it's visible. * diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index 725751894..e200e6f69 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -308,9 +308,7 @@ "properties": { "property": { "hidden": { - // https://github.com/whatwg/html/pull/7475 - // Blink only as of 2024-11 - "overrideType": "boolean", + "overrideType": "boolean | \"until-found\"", "nullable": false } }