fixed tests

Author: bachuv

client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java

@@ -304,13 +304,33 @@ public void startAndBlock() {
                                     .setCompletionToken(workItem.getCompletionToken())
                                     .build();
 
-                            // Externalize large payloads in outgoing response
-                            if (this.payloadHelper != null) {
-                                response = externalizeOrchestratorResponsePayloads(response);
+                            // Externalize large payloads and send (with optional chunking).
+                            // If externalization or chunking fails, report as orchestration failure.
+                            try {
+                                if (this.payloadHelper != null) {
+                                    response = externalizeOrchestratorResponsePayloads(response);
+                                }
+                                sendOrchestratorResponse(response);
+                            } catch (IllegalArgumentException | IllegalStateException e) {
+                                logger.log(Level.WARNING,
+                                    "Failed to send orchestrator response for instance '" +
+                                    orchestratorRequest.getInstanceId() + "': " + e.getMessage(), e);
+                                CompleteOrchestrationAction failAction = CompleteOrchestrationAction.newBuilder()
+                                    .setOrchestrationStatus(OrchestrationStatus.ORCHESTRATION_STATUS_FAILED)
+                                    .setFailureDetails(TaskFailureDetails.newBuilder()
+                                        .setErrorType(e.getClass().getName())
+                                        .setErrorMessage(e.getMessage())
+                                        .build())
+                                    .build();
+                                OrchestratorResponse failResponse = OrchestratorResponse.newBuilder()
+                                    .setInstanceId(orchestratorRequest.getInstanceId())
+                                    .setCompletionToken(workItem.getCompletionToken())
+                                    .addActions(OrchestratorAction.newBuilder()
+                                        .setCompleteOrchestration(failAction)
+                                        .build())
+                                    .build();
+                                this.sidecarClient.completeOrchestratorTask(failResponse);
                             }
-
-                            // Chunk the response if it exceeds gRPC message size limit
-                            sendOrchestratorResponse(response);
                         } else {
                             switch(versioningOptions.getFailureStrategy()) {
                                 case FAIL:

client/src/test/java/com/microsoft/durabletask/LargePayloadIntegrationTests.java

@@ -624,38 +624,24 @@ void autochunk_mixedActions_completesSuccessfully() throws TimeoutException {
     @Test
     void autochunk_singleActionExceedsChunkSize_failsWithClearError() throws TimeoutException {
         final String orchestratorName = "AutochunkOversizedOrch";
-        final String activityName = "OversizedActivity";
-        // Create an activity that returns a payload larger than 1MB chunk size
-        // Since externalization threshold is set very high, this will NOT be externalized
-        // and will try to be sent as a single action exceeding the chunk size
+        // Create an orchestrator that completes with a payload larger than 1MB chunk size.
+        // Externalization is NOT configured so the large payload stays inline in the
+        // CompleteOrchestration action, which exceeds the chunk size.
         final int payloadSize = 1_200_000;
 
-        // Use a store but set threshold very high so the payload won't be externalized
-        InMemoryPayloadStore store = new InMemoryPayloadStore();
-        LargePayloadOptions options = new LargePayloadOptions.Builder()
-            .setThresholdBytes(1_048_576) // 1 MiB — max allowed threshold
-            .setMaxExternalizedPayloadBytes(10_000_000)
-            .build();
-
         TestDurableTaskWorkerBuilder workerBuilder = this.createWorkerBuilder();
-        workerBuilder.innerBuilder.useExternalizedPayloads(store, options);
         workerBuilder.innerBuilder.setCompleteOrchestratorResponseChunkSizeBytes(
             DurableTaskGrpcWorkerBuilder.MIN_CHUNK_SIZE_BYTES);
         workerBuilder.addOrchestrator(orchestratorName, ctx -> {
-            String result = ctx.callActivity(activityName, null, String.class).await();
-            ctx.complete(result.length());
-        });
-        workerBuilder.addActivity(activityName, ctx -> {
             StringBuilder sb = new StringBuilder(payloadSize);
             for (int i = 0; i < payloadSize; i++) {
                 sb.append('Z');
             }
-            return sb.toString();
+            ctx.complete(sb.toString());
         });
         DurableTaskGrpcWorker worker = workerBuilder.buildAndStart();
 
         DurableTaskGrpcClientBuilder clientBuilder = this.createClientBuilder();
-        clientBuilder.useExternalizedPayloads(store, options);
         DurableTaskClient client = clientBuilder.build();
 
         try (worker; client) {
@@ -718,7 +704,7 @@ void largeInputOutputAndCustomStatus_allExternalized() throws TimeoutException {
     @Test
     void continueAsNew_withLargeCustomStatusAndFinalOutput() throws TimeoutException {
         final String orchestratorName = "ContinueAsNewAllOrch";
-        final int payloadSize = 800_000;
+        final int payloadSize = 1_000_000;
         final int iterations = 3;
 
         InMemoryPayloadStore store = new InMemoryPayloadStore();
@@ -771,8 +757,8 @@ void largeSubOrchestrationAndActivityOutput_combined() throws TimeoutException {
         final String parentOrchName = "CombinedParentOrch";
         final String childOrchName = "CombinedChildOrch";
         final String activityName = "CombinedActivity";
-        final int subOrchPayloadSize = 650_000;
-        final int activityPayloadSize = 820_000;
+        final int subOrchPayloadSize = 1_000_000;
+        final int activityPayloadSize = 1_000_000;
 
         InMemoryPayloadStore store = new InMemoryPayloadStore();
         LargePayloadOptions options = new LargePayloadOptions.Builder().build();