SplitButton needs label

[OjhaAditi25]

Added new rule for SplitButton to have an accessible name

Issue- #45

[aubreyquinn]

this is actually valid

[aubreyquinn]

The SplitButton component is a unique type of a button. Here are the valid ways to have an accessible SplitButton:

1. It has text content. If it has any text content at all, then it is accessible even if it has an icon.

e.g.
<SplitButton
menuButton={triggerProps}
primaryActionButton={primaryActionButtonProps}
icon={}
>
Example

    <SplitButton
      menuButton={triggerProps}
      primaryActionButton={primaryActionButtonProps}
    >
      Example
    </SplitButton>

2. If it does not have text content, then we must label the primary action button and not the SplitButton itself.

          <SplitButton
            menuButton={triggerProps}
            primaryActionButton={{
              ref: setPrimaryActionButtonRef,
              "aria-label": "With calendar icon only",
            }}
            icon={<CalendarMonthRegular />}
          />
   

We would need to adjust our ruleFactory to take in a custom checker function.

aria-label, aria-labelledby, htmlFor, aria-describedby, Label, Field and Tooltip are not valid ways to label the SplitButton.

[OjhaAditi25]

The SplitButton component is a unique type of a button. Here are the valid ways to have an accessible SplitButton:

1. It has text content. If it has any text content at all, then it is accessible even if it has an icon.

e.g. Example

    <SplitButton
      menuButton={triggerProps}
      primaryActionButton={primaryActionButtonProps}
    >
      Example
    </SplitButton>

2. If it does not have text content, then we must label the primary action button and not the SplitButton itself.

          <SplitButton
            menuButton={triggerProps}
            primaryActionButton={{
              ref: setPrimaryActionButtonRef,
              "aria-label": "With calendar icon only",
            }}
            icon={<CalendarMonthRegular />}
          />
   

We would need to adjust our ruleFactory to take in a custom checker function.

aria-label, aria-labelledby, htmlFor, aria-describedby, Label, Field and Tooltip are not valid ways to label the SplitButton.

Thank you @aubreyquinn. I have updated rule accordingly.
I didn't update/use factory function, may be if its okay I will handle it separately.

[OjhaAditi25]

The SplitButton component is a unique type of a button. Here are the valid ways to have an accessible SplitButton:

1. It has text content. If it has any text content at all, then it is accessible even if it has an icon.

e.g. Example

    <SplitButton
      menuButton={triggerProps}
      primaryActionButton={primaryActionButtonProps}
    >
      Example
    </SplitButton>

2. If it does not have text content, then we must label the primary action button and not the SplitButton itself.

          <SplitButton
            menuButton={triggerProps}
            primaryActionButton={{
              ref: setPrimaryActionButtonRef,
              "aria-label": "With calendar icon only",
            }}
            icon={<CalendarMonthRegular />}
          />
   

We would need to adjust our ruleFactory to take in a custom checker function.
aria-label, aria-labelledby, htmlFor, aria-describedby, Label, Field and Tooltip are not valid ways to label the SplitButton.

Thank you @aubreyquinn. I have updated rule accordingly. I didn't update/use factory function, may be if its okay I will handle it separately.

Updated to use factory rule