vmgs: dont upgrade vmgs encryption on auto #2280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents unintentional VMGS encryption method upgrades when the encryption policy is set to "Auto" by tracking whether the VMGS was provisioned during the current boot and using this information to disable higher-level encryption sources for pre-existing VMGS files.
Key changes:
- Added
provisioned_this_bootfield to track VMGS provisioning state - Modified encryption source selection logic to respect Auto policy for existing VMGS files
- Enhanced logging to show availability vs. active status of encryption sources
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vm/vmgs/vmgs/src/vmgs_impl.rs | Adds provisioned_this_boot field and accessor method to track VMGS provisioning state |
| openhcl/underhill_attestation/src/lib.rs | Updates encryption source selection logic to check provisioning state and prevent auto-upgrades for existing VMGS files |
stunes-ms
previously approved these changes
Oct 29, 2025
mebersol
added
the
backport_2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent unintentional migration of VMGS encryption methods, disable higher encryption sources when encryption policy is configured to Auto and the VMGS has already been provisioned.