fix

Author: heyitsaamir

packages/apps/src/microsoft/teams/apps/token_manager.py

@@ -62,7 +62,7 @@ async def get_graph_token(self, tenant_id: Optional[str] = None) -> Optional[Tok
         return await self._get_token("https://graph.microsoft.com/.default", tenant_id)
 
     async def _get_token(
-        self, scope: str | list[str], tenant_id: str | None = None, *, caller_name: str | None = None
+        self, scope: str, tenant_id: str | None = None, *, caller_name: str | None = None
     ) -> Optional[TokenProtocol]:
         credentials = self._credentials
         if self._credentials is None:
@@ -72,9 +72,19 @@ async def _get_token(
         if isinstance(credentials, (ClientCredentials, ManagedIdentityCredentials)):
             tenant_id_param = tenant_id or credentials.tenant_id or "botframework.com"
             msal_client = self._get_msal_client(tenant_id_param)
-            token_res: dict[str, Any] | None = await asyncio.to_thread(
-                lambda: msal_client.acquire_token_for_client(scope if isinstance(scope, list) else [scope])
-            )
+
+            # Handle different acquire_token_for_client signatures
+            if isinstance(msal_client, ManagedIdentityClient):
+                # ManagedIdentityClient expects resource as a keyword-only string parameter
+                token_res: dict[str, Any] | None = await asyncio.to_thread(
+                    lambda: msal_client.acquire_token_for_client(resource=scope)
+                )
+            else:
+                # ConfidentialClientApplication expects scopes as a list
+                token_res: dict[str, Any] | None = await asyncio.to_thread(
+                    lambda: msal_client.acquire_token_for_client([scope])
+                )
+
             if token_res.get("access_token", None):
                 access_token = token_res["access_token"]
                 return JsonWebToken(access_token)

stubs/msal/__init__.pyi

@@ -9,7 +9,7 @@ class ConfidentialClientApplication:
         self, client_id: str, *, client_credential: Optional[str] = None, authority: Optional[str] = None, **kwargs: Any
     ) -> None: ...
     def acquire_token_for_client(
-        self, scopes: list[str] | str, claims_challenge: Optional[str] = None, **kwargs: Any
+        self, scopes: list[str], claims_challenge: Optional[str] = None, **kwargs: Any
     ) -> dict[str, Any]: ...
 
 class SystemAssignedManagedIdentity:
@@ -34,6 +34,4 @@ class ManagedIdentityClient:
         http_cache: Optional[Any] = None,
         client_capabilities: Optional[list[str]] = None,
     ) -> None: ...
-    def acquire_token_for_client(
-        self, scopes: list[str] | str, claims_challenge: Optional[str] = None, **kwargs: Any
-    ) -> dict[str, Any]: ...
+    def acquire_token_for_client(self, *, resource: str, claims_challenge: Optional[str] = None) -> dict[str, Any]: ...