-
Notifications
You must be signed in to change notification settings - Fork 324
Exposed type for scm method provider #8811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
radhgupta
merged 8 commits into
microsoft:main
from
radhgupta:type-for-scmMethodProvider
Nov 3, 2025
Merged
Exposed type for scm method provider #8811
radhgupta
merged 8 commits into
microsoft:main
from
radhgupta:type-for-scmMethodProvider
Nov 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No changes needing a change description found. |
...csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProvider.cs
Outdated
Show resolved
Hide resolved
...csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProvider.cs
Outdated
Show resolved
Hide resolved
...csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
jorgerangel-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! It's looking good. I do see several build errors in CI that will also need to be addressed.
...csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProvider.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ScmMethodProviderCollectionTests.cs
Outdated
Show resolved
Hide resolved
...ent-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodKind.cs
Outdated
Show resolved
Hide resolved
jorgerangel-msft
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how method types are defined and used throughout the client model generator codebase. The main change is the introduction of a centralized
MethodTypeenum withinScmMethodProvider, replacing the previous scattered and internal definitions. This improves code clarity, maintainability, and consistency when handling different method types (CreateRequest, Protocol, Convenience) in both implementation and tests.Core Refactoring:
MethodTypeenum inScmMethodProvider, with clear documentation for each type. Added convenience properties for checking method type.Codebase-wide Adoption:
RestClientProvider,ScmMethodProviderCollection, and related classes to useScmMethodProvider.MethodTypeinstead of the old internal enum.Removal of Duplicated Enum:
MethodTypeenum fromRestClientProvider, ensuring there is a single source of truth for method types.Test Updates:
RestClientProviderTeststo use the newScmMethodProvider.MethodTypeenum for parameterized testing and assertionsThese changes collectively improve code consistency, reduce duplication, and make the handling of client method types more robust and maintainable.#8037