Bump ripgrep

[roblourens]

I noticed that our ripgrep build is still on v13 which is pretty old at this point. 14 appears to have some perf improvements https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md. I assume that you own this @osortega although I see that @rzhao271 has worked on it recently too? But I could help you with the process. Easier to update more often for smaller diffs.

https://github.com/microsoft/vscode-ripgrep
https://github.com/microsoft/ripgrep-prebuilt

[rzhao271]

I'm thinking that Osvaldo can create the PRs and that I can step in if there are new pipeline issues.

You'll want to update the ripgrep-prebuilt repository, then publish a new version of those binaries by pushing a new tag, then update the vscode-ripgrep repository, and then publish a new version of that npm package with a manual pipeline run.

[osortega]

@rzhao271 is working on this now given there's a lot of manual steps that are not documented

[rzhao271]

I realized just now that SteVen and I owned several of the patch files, so it made a lot more sense for me to reapply them anyway. Two of them don't seem to be necessary anymore.

[roblourens]

@rzhao271 please try to document anything that needs to be documented, I thought it used to be fairly straightforward. Thanks for looking at it thouhg.

[rzhao271]

Related: microsoft/ripgrep-prebuilt#38

[rzhao271]

I finally got the build working again, but it did involve a lot of steps. We still have to test the prebuilt binary and see whether it actually works in VS Code.

Some of the steps I took include

• Recreating patch files by checking out BurntSushi/ripgrep at 14.1.1, manually reapplying the changes, and running git diff > mypatchfilename.patch to generate a patch file that I can then copy back into ripgrep-prebuilt
• Updating the internal Azure DevOps feed that we use
• Removing some build flags that now turned the build red on the newer version. These removals should not give us new BinSkim alerts.

[rzhao271]

Some other debt items I'd like to work on

• Moving the ripgrep-prebuilt pipeline to the monacotools ADO so we can delete the vscode-org ADO project.
• Consolidating the patch files, considering that Windows and non-Windows platforms are patched completely differently nowadays.

[simon-id]

A commit fixing #26574 has been merged in ripgrep's master. The issue has 81 👍 and it really cripples any search in a subdirectory with a lot of ignored files (that are not being ignored because of the bug).
Would it be possible to wait a bit for next ripgrep release (i assume will be very soon), and bump ripgrep to 14.2.0/14.1.2 instead of 14.1.1 ?
I see @osortega already bumped the prebuilds to 14.1.1. It's probably better to wait for 14.2.0 and only then update the prebuilds+vscode/ripgrep+vscode, instead of having to go through the whole cycle for both 14.1.1 and 14.2.0 ?

[leonheess]

please listen to @simon-id's request, everyone working with mono repos struggles with this on a daily basis. we even had to write a script that copies each line of our .gitignore to search.exclude.