Merge pull request #2 from mikanyg/development

mikanyg · web-flow · commit 50da002d738d · 2018-05-23T23:12:39.000+02:00
Support for IDateTimeToggleValueProvider in all 3 Azure providers
diff --git a/src/FeatureToggle.Azure.DocumentDB/FeatureToggle.Azure.DocumentDB.csproj b/src/FeatureToggle.Azure.DocumentDB/FeatureToggle.Azure.DocumentDB.csproj
@@ -9,10 +9,13 @@
     <Copyright>Copyright © 2018</Copyright>
     <RepositoryType>Git</RepositoryType>
     <RepositoryUrl>https://github.com/mikanyg/FeatureToggle.Azure.git</RepositoryUrl>
-    <PackageReleaseNotes>1.0.0
+    <PackageReleaseNotes>1.1.0
+- Provider implements IDateTimeToggleValueProvider. Can be used as provider for feature toggles inheriting from FeatureToggle.EnabledOnOrAfterDateFeatureToggle or FeatureToggle.EnabledOnOrBeforeDateFeatureToggle.
+1.0.0
 - Initial release</PackageReleaseNotes>
     <PackageTags>FeatureToggle Toggle Azure DocumentDB DocDB CosmosDB NetStandard</PackageTags>
     <Description>FeatureToggle provider for storing feature toggles in Azure DocumentDB.</Description>
+    <Version>1.1.0</Version>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/FeatureToggle.Azure.DocumentDB/Providers/BooleanFeatureToggleDocument.cs b/src/FeatureToggle.Azure.DocumentDB/Providers/BooleanFeatureToggleDocument.cs
@@ -0,0 +1,14 @@
+﻿namespace FeatureToggle.Azure.Providers
+{
+    public class BooleanFeatureToggleDocument : FeatureToggleDocument
+    {
+        public BooleanFeatureToggleDocument() : base() { }        
+
+        public BooleanFeatureToggleDocument(string toggleName) : base(toggleName)
+        {            
+            Enabled = false;
+        }
+                
+        public bool Enabled { get; set; }
+    }
+}
diff --git a/src/FeatureToggle.Azure.DocumentDB/Providers/DateTimeFeatureToggleDocument.cs b/src/FeatureToggle.Azure.DocumentDB/Providers/DateTimeFeatureToggleDocument.cs
@@ -0,0 +1,16 @@
+﻿using System;
+
+namespace FeatureToggle.Azure.Providers
+{
+    public class DateTimeFeatureToggleDocument : FeatureToggleDocument
+    {
+        public DateTimeFeatureToggleDocument() : base() { }
+
+        public DateTimeFeatureToggleDocument(string toggleName) : base(toggleName)
+        {            
+            ToggleTimestamp = default(DateTime);
+        }
+                
+        public DateTime ToggleTimestamp { get; set; }
+    }
+}
diff --git a/src/FeatureToggle.Azure.DocumentDB/Providers/DocumentDbProvider.cs b/src/FeatureToggle.Azure.DocumentDB/Providers/DocumentDbProvider.cs
@@ -7,7 +7,7 @@
 
 namespace FeatureToggle.Azure.Providers
 {
-    public class DocumentDbProvider : IBooleanToggleValueProvider
+    public class DocumentDbProvider : IBooleanToggleValueProvider, IDateTimeToggleValueProvider
     {
         private static bool _collectionVerified;
 
@@ -34,43 +34,56 @@ public static void Configure(DocumentDbConfiguration config)
         }
 
         public bool EvaluateBooleanToggleValue(IFeatureToggle toggle)
+        {
+            return EvaluateToggleValue(toggle, document => document.Enabled, toggleName => new BooleanFeatureToggleDocument(toggleName));
+        }
+
+        public DateTime EvaluateDateTimeToggleValue(IFeatureToggle toggle)
+        {
+            return EvaluateToggleValue(toggle, document => document.ToggleTimestamp, toggleName => new DateTimeFeatureToggleDocument(toggleName));
+        }
+
+        private TValue EvaluateToggleValue<TDocument, TValue>(IFeatureToggle toggle, Func<TDocument, TValue> valueSelector, Func<string, TDocument> documentCreator) where TDocument : FeatureToggleDocument
         {
             var client = GetDocumentClient();
 
             var toggleName = toggle.GetType().Name;
 
-            bool toggleValue;
+            TValue toggleValue;
 
             try
             {
                 // Fetch feature toggle
-                var reponse = client.ReadDocumentAsync<FeatureToggleDocument>(
+                var response = client.ReadDocumentAsync<TDocument>(
                     UriFactory.CreateDocumentUri(Configuration.DatabaseId, Configuration.CollectionId, toggleName)).Result;
 
-                toggleValue = reponse.Document.Enabled;
+                var document = response.Document;
+
+                toggleValue = valueSelector(document);
             }
             catch (AggregateException ae) when (ae.InnerExceptions.First() is DocumentClientException ex && ex.StatusCode == HttpStatusCode.NotFound)
             {
                 Trace.TraceWarning($"Feature toggle '{toggleName}' not found.");
 
-                toggleValue = HandleMissingToggle(toggleName, client);
+                var newDocument = HandleMissingToggle(toggleName, () => documentCreator(toggleName), client);
+                toggleValue = valueSelector(newDocument);
             }
-            
+
             return toggleValue;
         }
 
-        private bool HandleMissingToggle(string toggleName, DocumentClient client)
+        private TDocument HandleMissingToggle<TDocument>(string toggleName, Func<TDocument> documentCreator, DocumentClient client) where TDocument : FeatureToggleDocument
         {
             if (!Configuration.AutoCreateFeature)
                 throw new ToggleConfigurationError($"Feature toggle '{toggleName}' does not exist. Either create it manually or configure the provider to auto create it.");
 
             Trace.TraceInformation($"AutoCreateFeature enabled, creating feature toggle '{toggleName}'.");
 
-            var document = new FeatureToggleDocument(toggleName);
+            var document = documentCreator();
             var response = client.CreateDocumentAsync(
                 UriFactory.CreateDocumentCollectionUri(Configuration.DatabaseId, Configuration.CollectionId), document, disableAutomaticIdGeneration:true).Result;
 
-            return document.Enabled;
+            return document;
         }
 
         private DocumentClient GetDocumentClient()
@@ -105,6 +118,6 @@ private DocumentClient GetDocumentClient()
             _collectionVerified = true;
 
             return client;
-        }
+        }        
     }
 }
diff --git a/src/FeatureToggle.Azure.DocumentDB/Providers/FeatureToggleDocument.cs b/src/FeatureToggle.Azure.DocumentDB/Providers/FeatureToggleDocument.cs
@@ -3,18 +3,16 @@
 
 namespace FeatureToggle.Azure.Providers
 {
-    public class FeatureToggleDocument
+    public abstract class FeatureToggleDocument
     {
-        public FeatureToggleDocument() { }
+        protected FeatureToggleDocument() { }
 
-        public FeatureToggleDocument(string toggleName)
+        protected FeatureToggleDocument(string toggleName)
         {
-            Id = toggleName ?? throw new ArgumentNullException(nameof(toggleName));
-            Enabled = false;
+            Id = toggleName ?? throw new ArgumentNullException(nameof(toggleName));            
         }
 
         [JsonProperty(PropertyName = "id")]
-        public string Id { get; set; }
-        public bool Enabled { get; set; }
+        public string Id { get; set; }        
     }
 }
diff --git a/src/FeatureToggle.Azure.ServiceFabric/FeatureToggle.Azure.ServiceFabric.csproj b/src/FeatureToggle.Azure.ServiceFabric/FeatureToggle.Azure.ServiceFabric.csproj
@@ -9,10 +9,13 @@
     <Copyright>Copyright © 2018</Copyright>
     <RepositoryType>Git</RepositoryType>
     <RepositoryUrl>https://github.com/mikanyg/FeatureToggle.Azure.git</RepositoryUrl>
-    <PackageReleaseNotes>1.0.0
+    <PackageReleaseNotes>1.1.0
+- Provider implements IDateTimeToggleValueProvider. Can be used as provider for feature toggles inheriting from FeatureToggle.EnabledOnOrAfterDateFeatureToggle or FeatureToggle.EnabledOnOrBeforeDateFeatureToggle.
+1.0.0
 - Initial release</PackageReleaseNotes>
     <PackageTags>FeatureToggle Toggle Azure ServiceFabric Fabric NetStandard</PackageTags>
     <Description>FeatureToggle provider for storing feature toggles in Service Fabric configuration packages.</Description>
+    <Version>1.1.0</Version>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/FeatureToggle.Azure.ServiceFabric/Providers/ServiceFabricConfigProvider.cs b/src/FeatureToggle.Azure.ServiceFabric/Providers/ServiceFabricConfigProvider.cs
@@ -4,7 +4,7 @@
 
 namespace FeatureToggle.Azure.Providers
 {
-    public class ServiceFabricConfigProvider : IBooleanToggleValueProvider
+    public class ServiceFabricConfigProvider : IBooleanToggleValueProvider, IDateTimeToggleValueProvider
     {
         private const string KeyNotFoundInSettingsMessage = "The key '{0}' was not found in settings.xml";
 
@@ -41,6 +41,19 @@ public bool EvaluateBooleanToggleValue(IFeatureToggle toggle)
             return ParseBooleanConfigString(configValue, key);
         }
 
+        public DateTime EvaluateDateTimeToggleValue(IFeatureToggle toggle)
+        {
+            var key = ExpectedAppSettingsKeyFor(toggle);
+
+            ValidateKeyExists(key);
+
+            var configValue = GetConfigValue(key);
+
+            var parser = new ConfigurationDateParser();
+
+            return parser.ParseDateTimeConfigString(configValue, key);
+        }
+
         private string ExpectedAppSettingsKeyFor(IFeatureToggle toggle)
         {
             var prefix = Configuration.UsePrefix ? ToggleConfigurationSettings.Prefix : string.Empty;
@@ -88,6 +101,6 @@ private string[] GetConfigKeysInSection()
             
             var section = settings.Sections[Configuration.ConfigSectionName];
             return section.Parameters.Select(p => p.Name).ToArray();
-        }
+        }        
     }
 }
diff --git a/src/FeatureToggle.Azure.TableStorage/FeatureToggle.Azure.TableStorage.csproj b/src/FeatureToggle.Azure.TableStorage/FeatureToggle.Azure.TableStorage.csproj
@@ -9,10 +9,13 @@
     <Copyright>Copyright © 2018</Copyright>
     <RepositoryType>Git</RepositoryType>
     <RepositoryUrl>https://github.com/mikanyg/FeatureToggle.Azure.git</RepositoryUrl>
-    <PackageReleaseNotes>1.0.0
+    <PackageReleaseNotes>1.1.0
+- Provider implements IDateTimeToggleValueProvider. Can be used as provider for feature toggles inheriting from FeatureToggle.EnabledOnOrAfterDateFeatureToggle or FeatureToggle.EnabledOnOrBeforeDateFeatureToggle.
+1.0.0
 - Initial release</PackageReleaseNotes>
     <PackageTags>FeatureToggle Toggle Azure TableStorage Table Storage NetStandard</PackageTags>
     <Description>FeatureToggle provider for storing feature toggles in Azure Table storage.</Description>
+    <Version>1.1.0</Version>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/FeatureToggle.Azure.TableStorage/Providers/BooleanFeatureToggleEntity.cs b/src/FeatureToggle.Azure.TableStorage/Providers/BooleanFeatureToggleEntity.cs
@@ -0,0 +1,14 @@
+﻿namespace FeatureToggle.Azure.Providers
+{
+    public class BooleanFeatureToggleEntity : FeatureToggleEntity
+    {
+        public BooleanFeatureToggleEntity() : base() { }
+
+        public BooleanFeatureToggleEntity(string componentName, string toggleName) : base(componentName, toggleName)
+        {
+            Enabled = false;
+        }
+
+        public bool Enabled { get; set; }
+    }
+}
diff --git a/src/FeatureToggle.Azure.TableStorage/Providers/DateTimeFeatureToggleEntity.cs b/src/FeatureToggle.Azure.TableStorage/Providers/DateTimeFeatureToggleEntity.cs
@@ -0,0 +1,16 @@
+﻿using System;
+
+namespace FeatureToggle.Azure.Providers
+{
+    public class DateTimeFeatureToggleEntity : FeatureToggleEntity
+    {
+        public DateTimeFeatureToggleEntity() : base() { }
+
+        public DateTimeFeatureToggleEntity(string componentName, string toggleName) : base(componentName, toggleName)
+        {
+            ToggleTimestamp = new DateTime(1900, 1, 1); // Table Storage does not support DateTime.Min
+        }
+
+        public DateTime ToggleTimestamp { get; set; }
+    }
+}
diff --git a/src/FeatureToggle.Azure.TableStorage/Providers/FeatureToggleEntity.cs b/src/FeatureToggle.Azure.TableStorage/Providers/FeatureToggleEntity.cs
@@ -3,17 +3,14 @@
 
 namespace FeatureToggle.Azure.Providers
 {
-    public class FeatureToggleEntity : TableEntity
+    public abstract class FeatureToggleEntity : TableEntity
     {
-        public FeatureToggleEntity() { }
+        protected FeatureToggleEntity() { }
 
-        public FeatureToggleEntity(string componentName, string toggleName)
+        protected FeatureToggleEntity(string componentName, string toggleName)
         {
             PartitionKey = componentName ?? throw new ArgumentNullException(nameof(componentName));
-            RowKey = toggleName ?? throw new ArgumentNullException(nameof(toggleName));
-            Enabled = false;
-        }
-
-        public bool Enabled { get; set; }
+            RowKey = toggleName ?? throw new ArgumentNullException(nameof(toggleName));            
+        }        
     }
 }
diff --git a/src/FeatureToggle.Azure.TableStorage/Providers/TableStorageProvider.cs b/src/FeatureToggle.Azure.TableStorage/Providers/TableStorageProvider.cs
@@ -1,11 +1,11 @@
-﻿using System;
-using System.Diagnostics;
-using Microsoft.WindowsAzure.Storage;
+﻿using Microsoft.WindowsAzure.Storage;
 using Microsoft.WindowsAzure.Storage.Table;
+using System;
+using System.Diagnostics;
 
 namespace FeatureToggle.Azure.Providers
 {
-    public class TableStorageProvider : IBooleanToggleValueProvider
+    public class TableStorageProvider : IBooleanToggleValueProvider, IDateTimeToggleValueProvider
     {
         private static bool _tableVerified;
 
@@ -27,43 +27,54 @@ public static void Configure(TableStorageConfiguration config)
         }
 
         public bool EvaluateBooleanToggleValue(IFeatureToggle toggle)
+        {
+            return EvaluateToggleValue(toggle, entity => entity.Enabled, (componentName, toggleName) => new BooleanFeatureToggleEntity(componentName, toggleName));
+        }
+
+        public DateTime EvaluateDateTimeToggleValue(IFeatureToggle toggle)
+        {
+            return EvaluateToggleValue(toggle, entity => entity.ToggleTimestamp, (componentName, toggleName) => new DateTimeFeatureToggleEntity(componentName, toggleName));
+        }
+
+        private TValue EvaluateToggleValue<TEntity, TValue>(IFeatureToggle toggle, Func<TEntity, TValue> valueSelector, Func<string, string, TEntity> entityCreator) where TEntity : FeatureToggleEntity
         {
             var table = GetCloudTable();
-            
+
             var componentName = Configuration.PartitionKeyResolver(toggle); // Defaults to assembly name of the feature toggle (used as partitionkey)
             var toggleName = toggle.GetType().Name;
 
             // Fetch feature toggle
             var retrievedResult = table.ExecuteAsync(
-                TableOperation.Retrieve<FeatureToggleEntity>(componentName, toggleName)).Result;
+                TableOperation.Retrieve<TEntity>(componentName, toggleName)).Result;
 
-            bool toggleValue;
-            
-            if (retrievedResult.Result is FeatureToggleEntity featureToggle)
+            TValue toggleValue;
+
+            if (retrievedResult.Result is TEntity entity)
             {
-                toggleValue = featureToggle.Enabled;
+                toggleValue = valueSelector(entity);
             }
             else
             {
                 Trace.TraceWarning($"Feature toggle '{toggleName}' not found.");
 
-                toggleValue = HandleMissingToggle(toggleName, componentName, table);
+                var newEntity = HandleMissingToggle(toggleName, () => entityCreator(componentName, toggleName), table);
+                toggleValue = valueSelector(newEntity);
             }
 
             return toggleValue;
-        }
+        }        
 
-        private bool HandleMissingToggle(string toggleName, string componentName, CloudTable table)
+        private TEntity HandleMissingToggle<TEntity>(string toggleName, Func<TEntity> entityCreator, CloudTable table) where TEntity : FeatureToggleEntity
         {
             if (!Configuration.AutoCreateFeature)
                 throw new ToggleConfigurationError($"Feature toggle '{toggleName}' does not exist. Either create it manually or configure the provider to auto create it.");
 
             Trace.TraceInformation($"AutoCreateFeature enabled, creating feature toggle '{toggleName}'.");
 
-            var entity = new FeatureToggleEntity(componentName, toggleName);
+            var entity = entityCreator();
             var result = table.ExecuteAsync(TableOperation.Insert(entity)).Result;
 
-            return entity.Enabled;
+            return entity;
         }
 
         private CloudTable GetCloudTable()
@@ -91,6 +102,6 @@ private CloudTable GetCloudTable()
             _tableVerified = true;
 
             return table;
-        }
+        }        
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`namespace FeatureToggle.Azure.Providers`
`9`	`9`	`{`
`10`		`- public class DocumentDbProvider : IBooleanToggleValueProvider`
	`10`	`+ public class DocumentDbProvider : IBooleanToggleValueProvider, IDateTimeToggleValueProvider`
`11`	`11`	`{`
`12`	`12`	`private static bool _collectionVerified;`
`13`	`13`
`@@ -34,43 +34,56 @@ public static void Configure(DocumentDbConfiguration config)`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`public bool EvaluateBooleanToggleValue(IFeatureToggle toggle)`
	`37`	`+ {`
	`38`	`+ return EvaluateToggleValue(toggle, document => document.Enabled, toggleName => new BooleanFeatureToggleDocument(toggleName));`
	`39`	`+ }`
	`40`	`+`
	`41`	`+ public DateTime EvaluateDateTimeToggleValue(IFeatureToggle toggle)`
	`42`	`+ {`
	`43`	`+ return EvaluateToggleValue(toggle, document => document.ToggleTimestamp, toggleName => new DateTimeFeatureToggleDocument(toggleName));`
	`44`	`+ }`
	`45`	`+`
	`46`	`+ private TValue EvaluateToggleValue<TDocument, TValue>(IFeatureToggle toggle, Func<TDocument, TValue> valueSelector, Func<string, TDocument> documentCreator) where TDocument : FeatureToggleDocument`
`37`	`47`	`{`
`38`	`48`	`var client = GetDocumentClient();`
`39`	`49`
`40`	`50`	`var toggleName = toggle.GetType().Name;`
`41`	`51`
`42`		`- bool toggleValue;`
	`52`	`+ TValue toggleValue;`
`43`	`53`
`44`	`54`	`try`
`45`	`55`	`{`
`46`	`56`	`// Fetch feature toggle`
`47`		`- var reponse = client.ReadDocumentAsync<FeatureToggleDocument>(`
	`57`	`+ var response = client.ReadDocumentAsync<TDocument>(`
`48`	`58`	`UriFactory.CreateDocumentUri(Configuration.DatabaseId, Configuration.CollectionId, toggleName)).Result;`
`49`	`59`
`50`		`- toggleValue = reponse.Document.Enabled;`
	`60`	`+ var document = response.Document;`
	`61`	`+`
	`62`	`+ toggleValue = valueSelector(document);`
`51`	`63`	`}`
`52`	`64`	`catch (AggregateException ae) when (ae.InnerExceptions.First() is DocumentClientException ex && ex.StatusCode == HttpStatusCode.NotFound)`
`53`	`65`	`{`
`54`	`66`	`Trace.TraceWarning($"Feature toggle '{toggleName}' not found.");`
`55`	`67`
`56`		`- toggleValue = HandleMissingToggle(toggleName, client);`
	`68`	`+ var newDocument = HandleMissingToggle(toggleName, () => documentCreator(toggleName), client);`
	`69`	`+ toggleValue = valueSelector(newDocument);`
`57`	`70`	`}`
`58`		`-`
	`71`	`+`
`59`	`72`	`return toggleValue;`
`60`	`73`	`}`
`61`	`74`
`62`		`- private bool HandleMissingToggle(string toggleName, DocumentClient client)`
	`75`	`+ private TDocument HandleMissingToggle<TDocument>(string toggleName, Func<TDocument> documentCreator, DocumentClient client) where TDocument : FeatureToggleDocument`
`63`	`76`	`{`
`64`	`77`	`if (!Configuration.AutoCreateFeature)`
`65`	`78`	`throw new ToggleConfigurationError($"Feature toggle '{toggleName}' does not exist. Either create it manually or configure the provider to auto create it.");`
`66`	`79`
`67`	`80`	`Trace.TraceInformation($"AutoCreateFeature enabled, creating feature toggle '{toggleName}'.");`
`68`	`81`
`69`		`- var document = new FeatureToggleDocument(toggleName);`
	`82`	`+ var document = documentCreator();`
`70`	`83`	`var response = client.CreateDocumentAsync(`
`71`	`84`	`UriFactory.CreateDocumentCollectionUri(Configuration.DatabaseId, Configuration.CollectionId), document, disableAutomaticIdGeneration:true).Result;`
`72`	`85`
`73`		`- return document.Enabled;`
	`86`	`+ return document;`
`74`	`87`	`}`
`75`	`88`
`76`	`89`	`private DocumentClient GetDocumentClient()`
`@@ -105,6 +118,6 @@ private DocumentClient GetDocumentClient()`
`105`	`118`	`_collectionVerified = true;`
`106`	`119`
`107`	`120`	`return client;`
`108`		`- }`
	`121`	`+ }`
`109`	`122`	`}`
`110`	`123`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,18 +3,16 @@`
`3`	`3`
`4`	`4`	`namespace FeatureToggle.Azure.Providers`
`5`	`5`	`{`
`6`		`- public class FeatureToggleDocument`
	`6`	`+ public abstract class FeatureToggleDocument`
`7`	`7`	`{`
`8`		`- public FeatureToggleDocument() { }`
	`8`	`+ protected FeatureToggleDocument() { }`
`9`	`9`
`10`		`- public FeatureToggleDocument(string toggleName)`
	`10`	`+ protected FeatureToggleDocument(string toggleName)`
`11`	`11`	`{`
`12`		`- Id = toggleName ?? throw new ArgumentNullException(nameof(toggleName));`
`13`		`- Enabled = false;`
	`12`	`+ Id = toggleName ?? throw new ArgumentNullException(nameof(toggleName));`
`14`	`13`	`}`
`15`	`14`
`16`	`15`	`[JsonProperty(PropertyName = "id")]`
`17`		`- public string Id { get; set; }`
`18`		`- public bool Enabled { get; set; }`
	`16`	`+ public string Id { get; set; }`
`19`	`17`	`}`
`20`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`namespace FeatureToggle.Azure.Providers`
`6`	`6`	`{`
`7`		`- public class ServiceFabricConfigProvider : IBooleanToggleValueProvider`
	`7`	`+ public class ServiceFabricConfigProvider : IBooleanToggleValueProvider, IDateTimeToggleValueProvider`
`8`	`8`	`{`
`9`	`9`	`private const string KeyNotFoundInSettingsMessage = "The key '{0}' was not found in settings.xml";`
`10`	`10`
`@@ -41,6 +41,19 @@ public bool EvaluateBooleanToggleValue(IFeatureToggle toggle)`
`41`	`41`	`return ParseBooleanConfigString(configValue, key);`
`42`	`42`	`}`
`43`	`43`
	`44`	`+ public DateTime EvaluateDateTimeToggleValue(IFeatureToggle toggle)`
	`45`	`+ {`
	`46`	`+ var key = ExpectedAppSettingsKeyFor(toggle);`
	`47`	`+`
	`48`	`+ ValidateKeyExists(key);`
	`49`	`+`
	`50`	`+ var configValue = GetConfigValue(key);`
	`51`	`+`
	`52`	`+ var parser = new ConfigurationDateParser();`
	`53`	`+`
	`54`	`+ return parser.ParseDateTimeConfigString(configValue, key);`
	`55`	`+ }`
	`56`	`+`
`44`	`57`	`private string ExpectedAppSettingsKeyFor(IFeatureToggle toggle)`
`45`	`58`	`{`
`46`	`59`	`var prefix = Configuration.UsePrefix ? ToggleConfigurationSettings.Prefix : string.Empty;`
`@@ -88,6 +101,6 @@ private string[] GetConfigKeysInSection()`
`88`	`101`
`89`	`102`	`var section = settings.Sections[Configuration.ConfigSectionName];`
`90`	`103`	`return section.Parameters.Select(p => p.Name).ToArray();`
`91`		`- }`
	`104`	`+ }`
`92`	`105`	`}`
`93`	`106`	`}`