🎨 harmonize invoice and financial docs line item classes

Author: ianardee

mindee/documents/financial_document/financial_document_v1_line_item.py

@@ -26,8 +26,6 @@ class FinancialDocumentV1LineItem(FieldPositionMixin, FieldConfidenceMixin):
     """The item total amount."""
     unit_price: Optional[float]
     """The item unit price."""
-    confidence: float = 0.0
-    """Confidence score"""
     page_n: int
     """The document page on which the information was found."""
 

mindee/documents/invoice/invoice_v4.py

@@ -2,7 +2,7 @@
 
 from mindee.documents.base import Document, TypeApiPrediction, clean_out_string
 from mindee.documents.invoice import checks, reconstruct
-from mindee.documents.invoice.line_item_v4 import InvoiceLineItemV4
+from mindee.documents.invoice.invoice_v4_line_item import InvoiceV4LineItem
 from mindee.fields.amount import AmountField
 from mindee.fields.classification import ClassificationField
 from mindee.fields.company_registration import CompanyRegistrationField
@@ -48,7 +48,7 @@ class InvoiceV4(Document):
     """Customer company registration numbers"""
     supplier_payment_details: List[PaymentDetails]
     """Payment details"""
-    line_items: List[InvoiceLineItemV4]
+    line_items: List[InvoiceV4LineItem]
     """Details of line items"""
 
     def __init__(
@@ -119,7 +119,7 @@ def _build_from_api_prediction(
             for payment_detail in api_prediction["supplier_payment_details"]
         ]
         self.line_items = [
-            InvoiceLineItemV4(prediction=line_item, page_id=page_n)
+            InvoiceV4LineItem(prediction=line_item, page_id=page_n)
             for line_item in api_prediction["line_items"]
         ]
         self.total_amount = AmountField(api_prediction["total_amount"], page_id=page_n)

mindee/documents/invoice/line_item_v4.py renamed to mindee/documents/invoice/invoice_v4_line_item.py

@@ -1,14 +1,15 @@
 from typing import Optional
 
 from mindee.fields.base import (
+    FieldConfidenceMixin,
     FieldPositionMixin,
     TypePrediction,
     float_to_string,
     to_opt_float,
 )
 
 
-class InvoiceLineItemV4(FieldPositionMixin):
+class InvoiceV4LineItem(FieldPositionMixin, FieldConfidenceMixin):
     product_code: Optional[str]
     """The product code referring to the item."""
     description: Optional[str]
@@ -33,18 +34,14 @@ def __init__(
         prediction: TypePrediction,
         page_id: Optional[int] = None,
     ):
+        self._set_confidence(prediction)
         self._set_position(prediction)
 
         if page_id is None:
             self.page_n = prediction["page_id"]
         else:
             self.page_n = page_id
 
-        try:
-            self.confidence = float(prediction["confidence"])
-        except (KeyError, TypeError):
-            pass
-
         self.product_code = prediction["product_code"]
         self.description = prediction["description"]
         self.quantity = to_opt_float(prediction, "quantity")