forked from xroche/httrack
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
This is a regression compared to the upstream 3.49.2 release that binaries are provided for. This is caused by #9
I've not set an HTTPS proxy or checked the checkbox to use the proxy for HTTPS, but opt->https_proxy ends up true anyway, and so https://github.com/mitchcapper/httrack/pull/9/files#diff-3df488ec9336b33abf71a0a722dbcb55bc19212fb2d082ce2ef68376b0a8281bR1958 means I don't get HTTPS at all.
I think it's getting forcibly enabled because https://github.com/mitchcapper/httrack-windows/blob/master/WinHTTrack/Shell.cpp#L2480-L2481
MyWriteProfileInt(path, strSection, "UseHTTPProxyForFTP", maintab->m_option10.m_ftpprox);
MyWriteProfileInt(path, strSection, "UseHTTPProxyForHTTPS", maintab->m_option10.m_ftpprox);should instead be
MyWriteProfileInt(path, strSection, "UseHTTPProxyForFTP", maintab->m_option10.m_ftpprox);
MyWriteProfileInt(path, strSection, "UseHTTPProxyForHTTPS", maintab->m_option10.m_sslproxy);but I'm not 100% sure what the intended behaviour is - maybe that's not a fix on its own and it's sensible to disable opt->https_proxy unless there's actually a proxy specified.
Metadata
Metadata
Assignees
Labels
No labels