-
-
Notifications
You must be signed in to change notification settings - Fork 406
Closed
Description
As mentioned in PR #82 from ParamHelpers I started to use expressions within the mlr learners. The first steps have already been made, as you can see here.
In general, it is now possible to define expressions within the parameters of a learner. However, due to the high complexity, this now raises new issues on other ends of mlr. Here are some problems that came up:
weightedClassWrapperdid not update thelearnerto thetask; why does this not work? I mean,trainLearner.WeightedClassesWrapperinternally callstrain, which actually adapts thelearner- in
test_base_Learner.Rthe following call failsexpect_error(makeLearner("classif.__mlrmocklearners__5"), "used 'expression'"), because PH now wants to have"a"in its dictionary (because parameter"b"requiresexpression(a == "x")).. do you have an idea, how to avoid this?
There are probably a lot more bugs coming up afterwards, but I thought it's best to start at some point and tackle them step-by-step..