-
-
Couldn't load subscription status.
- Fork 3.1k
Description
Tooling Suggestion Checklist
- I have tried restarting my IDE and the issue persists.
- I have pulled the latest
mainbranch of the repository. - I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
- I have searched for related issues and issues with the
faqlabel, but none matched my issue. - I want to provide a PR to resolve this
Overview
Mocha has a devDependency right now on a 4-year-old version of markdownlint-cli:
Line 159 in b2985b3
| "markdownlint-cli": "^0.30.0", |
This isn't a problem on its own. markdownlint-cli@0.30.0 works as-is. But it pulls in old dependencies that bloat our local node_modules size. For example, in #5484, we see it pulling in strip-json-comments@3:
$ npm ls strip-json-comments@3
mocha@11.7.4 /Users/josh/repos/mocha
├─┬ eslint@8.56.0
│ └─┬ @eslint/eslintrc@2.1.4
│ └── strip-json-comments@3.1.1
├─┬ jsdoc@3.6.11
│ └── strip-json-comments@3.1.1
└─┬ markdownlint-cli@0.30.0
└─┬ run-con@1.2.11
└── strip-json-comments@3.1.1
I think it'd be a good idea in general to bump it to the latest major version.
Additional Info
In theory it'd be nice to automatically upgrade all devDependencies. #5055 is blocked for now: #5055 (comment).
We'll have to do some work to identify potential breaking changes, there is no changelog file in the repo, just a list of releases in GitHub: https://github.com/igorshubovych/markdownlint-cli/releases
💖