Enable Google KMS and Azure Key Vault for publisher login tool #696
+641
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
force-pushed
the
joelverhagen/azkv
branch
2 times, most recently
from
4daf89b to
60001e6
Compare
Design doc is in this issue comment: modelcontextprotocol#482 (comment)
joelverhagen
force-pushed
the
joelverhagen/azkv
branch
from
60001e6 to
314f336
Compare
Add key length check # Conflicts: # cmd/publisher/auth/common.go
|
@rdimitrov - thanks for fixing |
|
@domdomegg, @toby - this PR is ready for review! Once this is in Microsoft will be able to publish to the MCP Registry :) |
domdomegg
reviewed
Oct 27, 2025
domdomegg
reviewed
Oct 27, 2025
domdomegg
reviewed
Oct 27, 2025
domdomegg
reviewed
Oct 27, 2025
domdomegg
reviewed
Oct 27, 2025
domdomegg
reviewed
Oct 27, 2025
Co-authored-by: adam jones <domdomegg+git@gmail.com>
Co-authored-by: adam jones <domdomegg+git@gmail.com>
Co-authored-by: adam jones <domdomegg+git@gmail.com>
Co-authored-by: adam jones <domdomegg+git@gmail.com>
domdomegg
previously approved these changes
Oct 27, 2025
domdomegg
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This allows the private key used for DNS or HTTP based authentication to be stored securely in a cloud key management system. These services often provide HSM storage which makes it very hard to leak the private key.
The full context is described in my design document here:
#482 (comment)
How Has This Been Tested?
I have tested it against PROD using an Ed25519 key stored in Google KMS. I have added unit tests. I have tested both ECDSA P-384 and Ed25519 with Az KV and Google KMS against a locally running server.
Breaking Changes
None intended.
Types of changes
Checklist
Additional context