Skip to content

Commit 7e4e949

Browse files
committed
fix(model-client): each call to ReplicatedModelJS.getBranch added another listener
1 parent e62e4f9 commit 7e4e949

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

model-client/src/jsMain/kotlin/org/modelix/model/client2/MutableModelTreeJsImpl.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ internal class MutableModelTreeJsImpl(
3535

3636
init {
3737
tree.addListener(changeListener)
38+
// TODO missing removeListener call
3839
}
3940

4041
override val rootNode: INodeJS

model-client/src/jsMain/kotlin/org/modelix/model/client2/ReplicatedModelJSImpl.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,15 @@ import org.modelix.model.mutable.withAutoTransactions
1010
import kotlin.js.Promise
1111

1212
internal class ReplicatedModelJSImpl(private val model: ReplicatedModel) : ReplicatedModelJS {
13+
14+
private val mutableModelTree = MutableModelTreeJsImpl(model.getVersionedModelTree().withAutoTransactions())
15+
1316
override fun dispose() {
1417
model.dispose()
1518
}
1619

1720
override fun getBranch(): MutableModelTreeJs {
18-
return MutableModelTreeJsImpl(model.getVersionedModelTree().withAutoTransactions())
21+
return mutableModelTree
1922
}
2023

2124
override fun getCurrentVersionInformation(): Promise<VersionInformationJS> {

0 commit comments

Comments
 (0)