Update e2e tests to fix modal regressions

Author: kraenhansen

packages/compass-e2e-tests/helpers/commands/open-settings-modal.ts

@@ -11,7 +11,7 @@ export async function openSettingsModal(
   });
 
   const settingsModalElement = browser.$(Selectors.SettingsModal);
-  await settingsModalElement.waitForExist();
+  await settingsModalElement.waitForDisplayed();
   if (tab) {
     await browser.clickVisible(Selectors.SettingsModalTabSelector(tab));
   }

packages/compass-e2e-tests/helpers/commands/save-favorite.ts

@@ -20,6 +20,8 @@ export async function saveFavorite(
   });
 
   await browser.clickVisible(Selectors.ConnectionModalSaveButton);
-  await browser.$(Selectors.ConnectionModal).waitForExist({ reverse: true });
+  await browser
+    .$(Selectors.ConnectionModal)
+    .waitForDisplayed({ reverse: true });
   return;
 }

packages/compass-e2e-tests/helpers/selectors.ts

@@ -25,8 +25,8 @@ export const SettingsInputElement = (settingName: string): string => {
 };
 
 // LG Modals
-export const LGModal = '[data-testid="lg-modal"]';
-export const LGModalClose = '[data-testid="lg-modal-close_button"]';
+export const LGModal = '[data-lgid="lg-modal"]';
+export const LGModalClose = '[data-lgid="lg-modal-close"]';
 
 // LG Toasts container (these test ids are used by LG in the toast and are not in the code anywhere).
 export const LGToastContainer = '[data-testid="lg-toast-scroll-container"]';