Potential memory leaks?

[faizanakram99]

ddd-bundle/src/Infrastructure/Console/PublishDomainEventsCommand.php

Line 84 in d13ad0b

$this->storedEventRepository->save($storedEvent);

Maybe we can also inject entity manager and clear it after saving storedEvents here ^, say if the batch size is reasonably high (or/and if the command remains running for too long and keeps on publishing and saving events), all stored events will stay in unit of work and might eat up memory?

[monteiro]

yes! we need a clear!

[faizanakram99]

We can also set the tracking strategy to explicit for StoredEvent entity, that way only elements that we persist will be in unit of work, nextUnpublishedEvents won't add elements to unit of work and we can clear entity manager after a bunch of Repository::save() calls safely

[monteiro]

Already added the clear in the save method, so we don't see it in the console command: 9505722