Skip to content

Conversation

@volkm
Copy link
Contributor

@volkm volkm commented Nov 28, 2025

As preparation for the CTMC change from rate matrix to probability matrix, I saw that the bisimulation needs a rate matrix. This PR uses adds a members transitionMatrix such that both probability and rate matrix could be used.

Also cleaned up the pragmas and includes in storm/storage/bisimulation.

@sjunges
Copy link
Contributor

sjunges commented Nov 29, 2025

Doesnt this cause a needless copy for DTMCs etc?

@volkm
Copy link
Contributor Author

volkm commented Nov 30, 2025

Yes, this does indeed copy the transition matrix. We do a copy for the backwardTransition already, so I thought that it might not be so urgent. But I see that we should try to avoid it.
I will check whether we can make it a reference or only use it for CTMCs.

@volkm
Copy link
Contributor Author

volkm commented Nov 30, 2025

Using const references did not work, so I will try to make specialized versions for CTMC.

@volkm
Copy link
Contributor Author

volkm commented Dec 2, 2025

I used templated functions to add specific behavior for the CTMC bisimulation (without the need for the rate matrix).

Interestingly, the newly added CTMC bisimulation tests yields different results on Mac and Linux. I will investigate it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants