Skip to content

Commit b528cce

Browse files
committed
Remove guards
1 parent eee604d commit b528cce

File tree

2 files changed

+1
-24
lines changed

2 files changed

+1
-24
lines changed

packages/utils/src/store/ReactStore.test.tsx

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -463,26 +463,6 @@ describe('ReactStore', () => {
463463
expect(calls).to.have.lengthOf(2); // No new calls after unsubscribe
464464
});
465465

466-
it('throws error when selector key does not exist', () => {
467-
const store = new ReactStore<CounterState, Record<string, never>, typeof selectors>(
468-
{ count: 5, multiplier: 3 },
469-
undefined,
470-
selectors,
471-
);
472-
473-
expect(() => {
474-
store.observeSelector('nonexistent' as any, () => {});
475-
}).to.throw('Base UI: Selector for key "nonexistent" is not defined.');
476-
});
477-
478-
it('throws error when store has no selectors', () => {
479-
const store = new ReactStore<CounterState>({ count: 5, multiplier: 3 });
480-
481-
expect(() => {
482-
store.observeSelector('doubled' as any, () => {});
483-
}).to.throw('Base UI: Selector for key "doubled" is not defined.');
484-
});
485-
486466
it('supports multiple observers on the same selector', () => {
487467
const store = new ReactStore<CounterState, Record<string, never>, typeof selectors>(
488468
{ count: 5, multiplier: 3 },

packages/utils/src/store/ReactStore.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,10 +276,7 @@ export class ReactStore<
276276
if (typeof selector === 'function') {
277277
selectFn = selector;
278278
} else {
279-
if (!this.selectors || !Object.hasOwn(this.selectors, selector)) {
280-
throw new Error(`Base UI: Selector for key "${String(selector)}" is not defined.`);
281-
}
282-
selectFn = this.selectors[selector] as ObserveSelector<State>;
279+
selectFn = this.selectors![selector] as ObserveSelector<State>;
283280
}
284281

285282
let prevValue = selectFn(this.state);

0 commit comments

Comments
 (0)