From c2b011d8e3175b6bfa10a90b99a931262b6bf644 Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Mon, 3 Aug 2020 14:28:55 -0400 Subject: [PATCH 1/2] Move axios request config option into main uploadTable options argument --- src/index.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/index.ts b/src/index.ts index b1debdb..2b6108e 100644 --- a/src/index.ts +++ b/src/index.ts @@ -62,6 +62,7 @@ export interface FileUploadOptionsSpec { data: string | File; key?: string; overwrite?: boolean; + axiosRequestConfig?: AxiosRequestConfig; } export interface CreateGraphOptionsSpec { @@ -145,8 +146,9 @@ class MultinetAPI { } public async uploadTable( - workspace: string, table: string, options: FileUploadOptionsSpec, config?: AxiosRequestConfig + workspace: string, table: string, options: FileUploadOptionsSpec ): Promise> { + const config = options.axiosRequestConfig; const headers = config ? config.headers : undefined; const params = config ? config.params : undefined; const { type, data, key, overwrite } = options; From d27d0437776355fa2bf1c851bd3f6b6b23e7a001 Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Wed, 5 Aug 2020 13:04:06 -0400 Subject: [PATCH 2/2] Separate axiosRequestConfig into a general options interface --- src/index.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/index.ts b/src/index.ts index 2b6108e..126c83c 100644 --- a/src/index.ts +++ b/src/index.ts @@ -44,6 +44,10 @@ export function validUploadType(type: string): type is UploadType { export type Direction = 'all' | 'incoming' | 'outgoing'; +export interface OptionsSpec { + axiosRequestConfig?: AxiosRequestConfig; +} + export interface TablesOptionsSpec { type?: TableType; } @@ -57,12 +61,11 @@ export type EdgesOptionsSpec = OffsetLimitSpec & { direction?: Direction; }; -export interface FileUploadOptionsSpec { +export interface FileUploadOptionsSpec extends OptionsSpec { type: UploadType; data: string | File; key?: string; overwrite?: boolean; - axiosRequestConfig?: AxiosRequestConfig; } export interface CreateGraphOptionsSpec {