From 2ae924a0a151ed049b8e4b1e4ab78aa5533c5d05 Mon Sep 17 00:00:00 2001 From: murtagh27 Date: Wed, 4 Oct 2023 15:34:06 +0200 Subject: [PATCH] fixing 3 bugs in torpedostore --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index 76a3cea..f0db83a 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -9,6 +9,9 @@ */ public class TorpedoStore { + //random letrhozasa + Random generator = new Random(); + // rate of failing to fire torpedos [0.0, 1.0] private double FAILURE_RATE = 0.0; //NOSONAR @@ -30,18 +33,18 @@ public TorpedoStore(int numberOfTorpedos){ public boolean fire(int numberOfTorpedos){ if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ - new IllegalArgumentException("numberOfTorpedos"); + throw new IllegalArgumentException("numberOfTorpedos"); } boolean success = false; // simulate random overheating of the launcher bay which prevents firing - Random generator = new Random(); + double r = generator.nextDouble(); if (r >= FAILURE_RATE) { // successful firing - this.torpedoCount =- numberOfTorpedos; + this.torpedoCount = -numberOfTorpedos; success = true; } else { // simulated failure