From fc9f64845ae56908c80e7bfee7e763b61c1bed7c Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Thu, 18 May 2023 19:12:23 -0400
Subject: [PATCH 01/12] :white_check_mark: Adds basic test for saveConfig

---
 config.go      |  6 +++---
 config_test.go | 14 ++++++++++++++
 2 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 config_test.go

diff --git a/config.go b/config.go
index 773fa02..5114faf 100644
--- a/config.go
+++ b/config.go
@@ -48,7 +48,7 @@ type config struct {
 var C config
 var tmpDir = ""
 
-func saveConfig(cfgpath string) error {
+func saveConfig(configurationPath string) error {
 	err := mapstructure.WeakDecode(viper.AllSettings(), &C)
 
 	if err != nil {
@@ -60,7 +60,7 @@ func saveConfig(cfgpath string) error {
 		return err
 	}
 
-	f, err := os.Create(cfgpath)
+	f, err := os.Create(configurationPath)
 	if err != nil {
 		return err
 	}
@@ -68,7 +68,7 @@ func saveConfig(cfgpath string) error {
 	defer f.Close()
 
 	f.WriteString(string(b))
-	log.Infof("config file saved to: %s", cfgpath)
+	log.Infof("config file saved to: %s", configurationPath)
 
 	return nil
 }
diff --git a/config_test.go b/config_test.go
new file mode 100644
index 0000000..34bd9bf
--- /dev/null
+++ b/config_test.go
@@ -0,0 +1,14 @@
+package main
+
+import (
+	"os"
+	"testing"
+)
+
+func TestSaveConfig(t *testing.T) {
+	currentDirectory, _ := os.Getwd()
+	got := saveConfig(currentDirectory)
+	if got != nil {
+		t.Errorf("got %q, wanted nil", got)
+	}
+}

From c9c34e86ebbf69668d97fbad4617c10a1e5dde13 Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Thu, 18 May 2023 19:14:26 -0400
Subject: [PATCH 02/12] :see_no_evil: ignores mt.json because test was writing
 over it

---
 .gitignore | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index 3b3b18a..2bb76df 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,8 @@
 mt
+
+# Ignore accidental changes to config
+mt.json
+
 dep
 dep/ffmpeg-*
 dep/ffmpeg_*/share

From 3f64371c6819202c7652ae07d33a08435f6439ef Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Fri, 19 May 2023 16:46:55 -0400
Subject: [PATCH 03/12] :white_check_mark: Expands on saveConfig test

---
 config_test.go | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/config_test.go b/config_test.go
index 34bd9bf..c835dd9 100644
--- a/config_test.go
+++ b/config_test.go
@@ -1,13 +1,21 @@
 package main
 
 import (
+	"fmt"
 	"os"
 	"testing"
 )
 
 func TestSaveConfig(t *testing.T) {
-	currentDirectory, _ := os.Getwd()
-	got := saveConfig(currentDirectory)
+	testFile, _ := os.CreateTemp("", "saveTest.json")
+	defer func(name string) {
+		err := os.Remove(name)
+		if err != nil {
+			fmt.Println("could not delete saveTest.json")
+		}
+	}(testFile.Name())
+
+	got := saveConfig(testFile.Name())
 	if got != nil {
 		t.Errorf("got %q, wanted nil", got)
 	}

From 6e0fc4f9b4825628f3beda65e2c2c8e80aebdfe0 Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Fri, 19 May 2023 17:59:23 -0400
Subject: [PATCH 04/12] :bulb: Add comment to config values

These comments can be referenced by godocs in the future.
---
 config.go | 113 ++++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 79 insertions(+), 34 deletions(-)

diff --git a/config.go b/config.go
index 5114faf..18576f6 100644
--- a/config.go
+++ b/config.go
@@ -9,40 +9,85 @@ import (
 )
 
 type config struct {
-	Numcaps            int    `json:"numcaps"`
-	Columns            int    `json:"columns"`
-	Padding            int    `json:"padding"`
-	Width              int    `json:"width"`
-	Font_All           string `json:"font_all"`
-	Font_Size          int    `json:"font_size"`
-	Disable_Timestamps bool   `json:"disable_timestamps"`
-	Verbose            bool   `json:"verbose"`
-	Single_Images      bool   `json:"single_images"`
-	Bg_Header          string `json:"bg_header"`
-	Fg_Header          string `json:"fg_header"`
-	Bg_Content         string `json:"bg_content"`
-	Header_Image       string `json:"header_image"`
-	Skip_Blank         bool   `json:"skip_blank"`
-	Header             bool   `json:"header"`
-	Header_Meta        bool   `json:"header_meta"`
-	Filter             string `json:"filter"`
-	Filename           string `json:"filename"`
-	From               string `json:"from"`
-	To                 string `json:"to"`
-	Skip_Existing      bool   `json:"skip_existing"`
-	Overwrite          bool   `json:"overwrite"`
-	SFW                bool   `json:"sfw"`
-	Watermark          string `json:"watermark"`
-	Fast               bool   `json:"fast"`
-	Watermark_All      string `json:"watermark_all"`
-	Comment            string `json:"comment"`
-	Skip_Blurry        bool   `json:"skip_blurry"`
-	Blur_Threshold     int    `json:"blur_threshold"`
-	Blank_Threshold    int    `json:"blank_threshold"`
-	Webvtt             bool   `json:"webvtt"`
-	Vtt                bool   `json:"vtt"`
-	Upload             bool   `json:"upload"`
-	Upload_URL         string `json:"upload_url"`
+	// Numcaps is the number of thumbnails to use in the contact sheet.
+	Numcaps int `json:"numcaps"`
+	// Columns are how many columns should be used in the contact sheet.
+	Columns int `json:"columns"`
+	// Padding is how much padding (in pixels) to add around thumbnails in the
+	// contact sheet.
+	Padding int `json:"padding"`
+	// Width is the width of a single thumbnail.
+	Width int `json:"width"`
+	// TODO is height missing?
+	// FontAll is the font to use in the header and timestamps.
+	Font_All string `json:"font_all"`
+	// FontSize is the font size to be used in the contact sheet.
+	Font_Size int `json:"font_size"`
+	// DisableTimestamps provides the ability to toggle timestamps in the
+	// contact sheet.
+	Disable_Timestamps bool `json:"disable_timestamps"`
+	// Verbose increases the logging.
+	Verbose bool `json:"verbose"`
+	// SingleImages will create a single image for each screenshot.
+	Single_Images bool `json:"single_images"`
+	// BgHeader set the background color of the contact sheet header (RGB).
+	Bg_Header string `json:"bg_header"`
+	// FgHeader sets the foreground color of the contact sheet header (RGB).
+	Fg_Header string `json:"fg_header"`
+	// BgContent sets the background color of the contact sheet context (RGB).
+	Bg_Content string `json:"bg_content"`
+	// HeaderImage sets the contact sheet header to be an image.
+	Header_Image string `json:"header_image"`
+	// SkipBlank sets the ability to skip up to three blank images. Can impact
+	// performance.
+	Skip_Blank bool `json:"skip_blank"`
+	// Header sets whether to create a header in the contact sheet.
+	Header bool `json:"header"`
+	// HeaderMeta sets whether to include codec, bitrate, and FPS to header.
+	Header_Meta bool `json:"header_meta"` // Required header to be true?
+	// Filter sets an optional filter on thumbnails. Options are:
+	//   - "greyscale" greyscale color palette?
+	//   - "invert"   invert image?
+	//   - "fancy"     ?
+	//   - "cross"     ?
+	Filter string `json:"filter"`
+	// Filename is the name of the contact sheet.
+	Filename string `json:"filename"`
+	// To is the starting timestamp.
+	From string `json:"from"`
+	// To is the ending timestamp.
+	To string `json:"to"`
+	// SkipExisting skips movie if there is and existing contact sheet.
+	Skip_Existing bool `json:"skip_existing"`
+	// Overwrite will enable the ability to overwrite existing contact sheets.
+	Overwrite bool `json:"overwrite"`
+	// SFW enables nude detection (EXPERIMENTAL).
+	SFW bool `json:"sfw"`
+	// Watermark sets a provided image as the watermark in the content sections
+	// of the contact sheet.
+	Watermark string `json:"watermark"`
+	// Fast enables faster creation of thumbnails. May result in duplicate screens.
+	Fast bool `json:"fast"`
+	// WatermarkAll sets a provided images as the watermark in each thumbnail.
+	Watermark_All string `json:"watermark_all"`
+	// Comment sets a line of text that will be displayed in the bottom-left corner
+	// of the contact sheet header.
+	Comment string `json:"comment"`
+	// SkipBlurry sets the ability to skip up to three blurry images. Can impact
+	// performance.
+	Skip_Blurry bool `json:"skip_blurry"`
+	// BlurThreshold sets the threshold for blur detection in thumbnails.
+	Blur_Threshold int `json:"blur_threshold"`
+	// BlankThreshold sets the threshold for blank detection in thumbnails.
+	Blank_Threshold int `json:"blank_threshold"`
+	// Webvtt generates a webtt file when enabled.
+	Webvtt bool `json:"webvtt"`
+	// Vtt ??
+	Vtt bool `json:"vtt"`
+	// Upload posts the generated contact sheet to a URL.
+	Upload bool `json:"upload"`
+	// UploadURL sets the upload URL.
+	Upload_URL string `json:"upload_url"`
 }
 
 var C config

From f3c7e808d7054b4d4f7691dc4d6ba2a5b419434c Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sat, 20 May 2023 17:11:51 -0400
Subject: [PATCH 05/12] :rotating_light: camelCasing struct

https://go.dev/doc/effective_go#names
---
 config.go | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/config.go b/config.go
index 18576f6..9d7d0dc 100644
--- a/config.go
+++ b/config.go
@@ -20,31 +20,31 @@ type config struct {
 	Width int `json:"width"`
 	// TODO is height missing?
 	// FontAll is the font to use in the header and timestamps.
-	Font_All string `json:"font_all"`
+	FontAll string `json:"font_all"`
 	// FontSize is the font size to be used in the contact sheet.
-	Font_Size int `json:"font_size"`
+	FontSize int `json:"font_size"`
 	// DisableTimestamps provides the ability to toggle timestamps in the
 	// contact sheet.
-	Disable_Timestamps bool `json:"disable_timestamps"`
+	DisableTimestamps bool `json:"disable_timestamps"`
 	// Verbose increases the logging.
 	Verbose bool `json:"verbose"`
 	// SingleImages will create a single image for each screenshot.
-	Single_Images bool `json:"single_images"`
+	SingleImages bool `json:"single_images"`
 	// BgHeader set the background color of the contact sheet header (RGB).
-	Bg_Header string `json:"bg_header"`
+	BgHeader string `json:"bg_header"`
 	// FgHeader sets the foreground color of the contact sheet header (RGB).
-	Fg_Header string `json:"fg_header"`
+	FgHeader string `json:"fg_header"`
 	// BgContent sets the background color of the contact sheet context (RGB).
-	Bg_Content string `json:"bg_content"`
+	BgContent string `json:"bg_content"`
 	// HeaderImage sets the contact sheet header to be an image.
-	Header_Image string `json:"header_image"`
+	HeaderImage string `json:"header_image"`
 	// SkipBlank sets the ability to skip up to three blank images. Can impact
 	// performance.
-	Skip_Blank bool `json:"skip_blank"`
+	SkipBlank bool `json:"skip_blank"`
 	// Header sets whether to create a header in the contact sheet.
 	Header bool `json:"header"`
 	// HeaderMeta sets whether to include codec, bitrate, and FPS to header.
-	Header_Meta bool `json:"header_meta"` // Required header to be true?
+	HeaderMeta bool `json:"header_meta"` // Required header to be true?
 	// Filter sets an optional filter on thumbnails. Options are:
 	//   - "greyscale" greyscale color palette?
 	//   - "invert"   invert image?
@@ -58,7 +58,7 @@ type config struct {
 	// To is the ending timestamp.
 	To string `json:"to"`
 	// SkipExisting skips movie if there is and existing contact sheet.
-	Skip_Existing bool `json:"skip_existing"`
+	SkipExisting bool `json:"skip_existing"`
 	// Overwrite will enable the ability to overwrite existing contact sheets.
 	Overwrite bool `json:"overwrite"`
 	// SFW enables nude detection (EXPERIMENTAL).
@@ -69,25 +69,25 @@ type config struct {
 	// Fast enables faster creation of thumbnails. May result in duplicate screens.
 	Fast bool `json:"fast"`
 	// WatermarkAll sets a provided images as the watermark in each thumbnail.
-	Watermark_All string `json:"watermark_all"`
+	WatermarkAll string `json:"watermark_all"`
 	// Comment sets a line of text that will be displayed in the bottom-left corner
 	// of the contact sheet header.
 	Comment string `json:"comment"`
 	// SkipBlurry sets the ability to skip up to three blurry images. Can impact
 	// performance.
-	Skip_Blurry bool `json:"skip_blurry"`
+	SkipBlurry bool `json:"skip_blurry"`
 	// BlurThreshold sets the threshold for blur detection in thumbnails.
-	Blur_Threshold int `json:"blur_threshold"`
+	BlurThreshold int `json:"blur_threshold"`
 	// BlankThreshold sets the threshold for blank detection in thumbnails.
-	Blank_Threshold int `json:"blank_threshold"`
-	// Webvtt generates a webtt file when enabled.
-	Webvtt bool `json:"webvtt"`
-	// Vtt ??
-	Vtt bool `json:"vtt"`
+	BlankThreshold int `json:"blank_threshold"`
+	// WebVTT generates a webtt file when enabled.
+	WebVTT bool `json:"webvtt"`
+	// VTT ??
+	VTT bool `json:"vtt"`
 	// Upload posts the generated contact sheet to a URL.
 	Upload bool `json:"upload"`
 	// UploadURL sets the upload URL.
-	Upload_URL string `json:"upload_url"`
+	UploadUrl string `json:"upload_url"`
 }
 
 var C config

From 28ef279af16e161661d5afd69b5bac4e82b02ace Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sat, 20 May 2023 18:37:43 -0400
Subject: [PATCH 06/12] :art: Moving default settings to config.go

Start of work to remove code from main(). Also making some default const if they are using in other files.
---
 config.go | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
 error.go  |  8 ++++++
 mt.go     | 73 ++++++++++---------------------------------------------
 3 files changed, 91 insertions(+), 61 deletions(-)
 create mode 100644 error.go

diff --git a/config.go b/config.go
index 9d7d0dc..6f6abfe 100644
--- a/config.go
+++ b/config.go
@@ -8,6 +8,14 @@ import (
 	"os"
 )
 
+const (
+	configName = "mt"
+	configType = "json"
+
+	blurThreshold  = 62
+	blankThreshold = 85
+)
+
 type config struct {
 	// Numcaps is the number of thumbnails to use in the contact sheet.
 	Numcaps int `json:"numcaps"`
@@ -93,6 +101,67 @@ type config struct {
 var C config
 var tmpDir = ""
 
+// configInit sets default variables and reads configuration file.
+func configInit() {
+	viper.AutomaticEnv()
+	viper.SetConfigName(configName)
+	viper.SetConfigType(configType)
+	viper.SetEnvPrefix("mt")
+
+	viper.AddConfigPath("./")
+	viper.AddConfigPath("/etc/mt/")
+	viper.AddConfigPath("$HOME/.mt")
+
+	// Set mt defaults
+	viper.SetDefault("numcaps", 4)
+	viper.SetDefault("columns", 2)
+	viper.SetDefault("padding", 10)
+	viper.SetDefault("width", 400)
+	viper.SetDefault("height", 0)
+	viper.SetDefault("font_all", "DroidSans.ttf") // Should this be Ubuntu.ttf to match readme?
+	viper.SetDefault("font_size", 12)
+	viper.SetDefault("disable_timestamps", false)
+	viper.SetDefault("timestamp_opacity", 1.0)
+	viper.SetDefault("filename", "{{.Path}}{{.Name}}.jpg")
+	viper.SetDefault("verbose", false)
+	viper.SetDefault("bg_content", "0,0,0")
+	viper.SetDefault("border", 0)
+	viper.SetDefault("from", "00:00:00")
+	viper.SetDefault("end", "00:00:00")
+	viper.SetDefault("single_images", false)
+	viper.SetDefault("header", true)
+	viper.SetDefault("font_dirs", []string{})
+	viper.SetDefault("bg_header", "0,0,0")
+	viper.SetDefault("fg_header", "255,255,255")
+	viper.SetDefault("header_image", "")
+	viper.SetDefault("header_meta", false)
+	viper.SetDefault("watermark", "")
+	viper.SetDefault("comment", "contact sheet created with mt (https://github.com/mutschler/mt)")
+	viper.SetDefault("watermark-all", "")
+	viper.SetDefault("filter", "none")
+	viper.SetDefault("skip_blank", false)
+	viper.SetDefault("skip_blurry", false)
+	viper.SetDefault("skip_existing", false)
+	viper.SetDefault("overwrite", false)
+	viper.SetDefault("sfw", false)
+	viper.SetDefault("fast", false)
+	viper.SetDefault("show_config", false)
+	viper.SetDefault("webvtt", false)
+	viper.SetDefault("vtt", false)
+	viper.SetDefault("blur_threshold", blurThreshold)
+	viper.SetDefault("blank_threshold", blankThreshold)
+	viper.SetDefault("upload", false)
+	viper.SetDefault("upload_url", "http://example.com/upload")
+	viper.SetDefault("skip_credits", false)
+	viper.SetDefault("interval", 0)
+
+	err := viper.ReadInConfig()
+	if _, ok := err.(viper.ConfigFileNotFoundError); ok {
+		log.Info("configuration file not found, using defaults")
+	}
+	log.Info("loaded config file")
+}
+
 func saveConfig(configurationPath string) error {
 	err := mapstructure.WeakDecode(viper.AllSettings(), &C)
 
@@ -107,7 +176,7 @@ func saveConfig(configurationPath string) error {
 
 	f, err := os.Create(configurationPath)
 	if err != nil {
-		return err
+		return ErrCannotSaveConfigFile
 	}
 
 	defer f.Close()
diff --git a/error.go b/error.go
new file mode 100644
index 0000000..8b8aecb
--- /dev/null
+++ b/error.go
@@ -0,0 +1,8 @@
+package main
+
+import "errors"
+
+var (
+	// ErrCannotSaveConfigFile occurs when a configuration file cannot be opened.
+	ErrCannotSaveConfigFile = errors.New("cannot save configuration file")
+)
diff --git a/mt.go b/mt.go
index 9f73bf2..d188475 100644
--- a/mt.go
+++ b/mt.go
@@ -39,8 +39,8 @@ var version string = GitVersion + " (" + FfmpegVersion + ") built on " + BuildTi
 var timestamps []string
 var numcaps int
 
-//gets the timestamp value ("HH:MM:SS") and returns an image
-//TODO: rework this to take any string and a bool for full width/centered text
+// gets the timestamp value ("HH:MM:SS") and returns an image
+// TODO: rework this to take any string and a bool for full width/centered text
 func drawTimestamp(timestamp string) image.Image {
 	var timestamped image.Image
 
@@ -555,49 +555,8 @@ func createHeader(fn string) []string {
 func main() {
 
 	runtime.GOMAXPROCS(runtime.NumCPU())
-	viper.SetConfigName("mt")
-	viper.SetEnvPrefix("mt")
-	viper.SetDefault("numcaps", 4)
-	viper.SetDefault("columns", 2)
-	viper.SetDefault("padding", 10)
-	viper.SetDefault("width", 400)
-	viper.SetDefault("height", 0)
-	viper.SetDefault("font_all", "DroidSans.ttf")
-	viper.SetDefault("font_size", 12)
-	viper.SetDefault("disable_timestamps", false)
-	viper.SetDefault("timestamp_opacity", 1.0)
-	viper.SetDefault("filename", "{{.Path}}{{.Name}}.jpg")
-	viper.SetDefault("verbose", false)
-	viper.SetDefault("bg_content", "0,0,0")
-	viper.SetDefault("border", 0)
-	viper.SetDefault("from", "00:00:00")
-	viper.SetDefault("end", "00:00:00")
-	viper.SetDefault("single_images", false)
-	viper.SetDefault("header", true)
-	viper.SetDefault("font_dirs", []string{})
-	viper.SetDefault("bg_header", "0,0,0")
-	viper.SetDefault("fg_header", "255,255,255")
-	viper.SetDefault("header_image", "")
-	viper.SetDefault("header_meta", false)
-	viper.SetDefault("watermark", "")
-	viper.SetDefault("comment", "contactsheet created with mt (https://github.com/mutschler/mt)")
-	viper.SetDefault("watermark-all", "")
-	viper.SetDefault("filter", "none")
-	viper.SetDefault("skip_blank", false)
-	viper.SetDefault("skip_blurry", false)
-	viper.SetDefault("skip_existing", false)
-	viper.SetDefault("overwrite", false)
-	viper.SetDefault("sfw", false)
-	viper.SetDefault("fast", false)
-	viper.SetDefault("show_config", false)
-	viper.SetDefault("webvtt", false)
-	viper.SetDefault("vtt", false)
-	viper.SetDefault("blur_threshold", 62)
-	viper.SetDefault("blank_threshold", 85)
-	viper.SetDefault("upload", false)
-	viper.SetDefault("upload_url", "http://example.com/upload")
-	viper.SetDefault("skip_credits", false)
-	viper.SetDefault("interval", 0)
+
+	configInit()
 
 	flag.IntP("numcaps", "n", viper.GetInt("numcaps"), "number of captures to make")
 	viper.BindPFlag("numcaps", flag.Lookup("numcaps"))
@@ -722,23 +681,11 @@ func main() {
 	flag.Bool("skip-credits", viper.GetBool("skip_credits"), "tries to skip ending credits from screencap creation by cutting off 4 minutes or 10 percent of the clip (defaults to false)")
 	viper.BindPFlag("skip_credits", flag.Lookup("skip-credits"))
 
-	viper.AutomaticEnv()
-
-	viper.SetConfigType("json")
-	viper.AddConfigPath("./")
-	viper.AddConfigPath("/etc/mt/")
-	viper.AddConfigPath("$HOME/.mt")
-
 	flag.Usage = func() {
 		fmt.Fprintf(os.Stderr, "Usage of %s: [flags] [file]\n", os.Args[0])
 		flag.PrintDefaults()
 	}
 
-	err := viper.ReadInConfig()
-	if err != nil {
-		fmt.Errorf("error reading config file: %s using default values", err)
-	}
-
 	flag.Parse()
 
 	if viper.GetBool("show_version") {
@@ -816,9 +763,10 @@ NOTE: fancy has best results if it is applied as last filter!
 	b, _ := json.Marshal(viper.AllSettings())
 	log.Debugf("config values: %s", b)
 
-	fontBytes, err = getFont(viper.GetString("font_all"))
-	if err != nil {
-		log.Warn("unable to load font, disableing timestamps and header")
+	var errFont error
+	fontBytes, errFont = getFont(viper.GetString("font_all"))
+	if errFont != nil {
+		log.Warn("unable to load font, disabling timestamps and header")
 	}
 
 	if viper.GetBool("show_config") {
@@ -831,6 +779,11 @@ NOTE: fancy has best results if it is applied as last filter!
 		os.Exit(1)
 	}
 
+	//
+	//
+	//
+	// End of main()
+
 	for _, movie := range flag.Args() {
 		mpath = movie
 		log.Infof("generating contact sheet for %s", movie)

From e5af8b002d798a5cb06047df2d073cd000acb29f Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sun, 21 May 2023 17:51:00 -0400
Subject: [PATCH 07/12] :art: Moving C to a local variable

C was only used in a single function and doesn't need to be exported
---
 config.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/config.go b/config.go
index 6f6abfe..85e95eb 100644
--- a/config.go
+++ b/config.go
@@ -98,7 +98,6 @@ type config struct {
 	UploadUrl string `json:"upload_url"`
 }
 
-var C config
 var tmpDir = ""
 
 // configInit sets default variables and reads configuration file.
@@ -163,13 +162,14 @@ func configInit() {
 }
 
 func saveConfig(configurationPath string) error {
-	err := mapstructure.WeakDecode(viper.AllSettings(), &C)
+	var currentConfig config
+	err := mapstructure.WeakDecode(viper.AllSettings(), &currentConfig)
 
 	if err != nil {
 		return err
 	}
 
-	b, err := json.MarshalIndent(&C, "", "    ")
+	b, err := json.MarshalIndent(&currentConfig, "", "    ")
 	if err != nil {
 		return err
 	}

From 16f3f3f00c633eade1f5f6d4c49eef1c96e1cfb0 Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sun, 21 May 2023 17:54:33 -0400
Subject: [PATCH 08/12] :fire: Deleting variable tmpDir

It was only being reference in a function that was not being called.
---
 config.go  |  2 --
 helpers.go | 27 ++-------------------------
 2 files changed, 2 insertions(+), 27 deletions(-)

diff --git a/config.go b/config.go
index 85e95eb..c441369 100644
--- a/config.go
+++ b/config.go
@@ -98,8 +98,6 @@ type config struct {
 	UploadUrl string `json:"upload_url"`
 }
 
-var tmpDir = ""
-
 // configInit sets default variables and reads configuration file.
 func configInit() {
 	viper.AutomaticEnv()
diff --git a/helpers.go b/helpers.go
index cbe5099..41c183b 100644
--- a/helpers.go
+++ b/helpers.go
@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"image"
 	"image/color"
-	"image/jpeg"
 	"io/ioutil"
 	"math/rand"
 	"os"
@@ -199,7 +198,7 @@ func isNudeImage(img image.Image) bool {
 	return isNude
 }
 
-//takes a string "0,0,0" and returns the RGBA color
+// takes a string "0,0,0" and returns the RGBA color
 func getImageColor(s string, fallback []int) color.RGBA {
 	colors := strings.Split(s, ",")
 	var r, g, b int
@@ -264,7 +263,7 @@ func constructSavePath(filename string, c int) string {
 	return buf.String()
 }
 
-//gets a filename (string) and returns the absolute path to save the image to...
+// gets a filename (string) and returns the absolute path to save the image to...
 func getSavePath(filename string, c int) string {
 	fname := constructSavePath(filename, c)
 
@@ -280,25 +279,3 @@ func getSavePath(filename string, c int) string {
 	}
 	return fname
 }
-
-// saves the image to a temporary location and returns the path
-func saveTempFile(img image.Image) string {
-	if tmpDir == "" {
-		tmpDir, _ = ioutil.TempDir("", "mt")
-	}
-
-	tmpFile, err := ioutil.TempFile(tmpDir, "mt")
-	if err != nil {
-		fmt.Print(err)
-	}
-
-	buf := new(bytes.Buffer)
-	_ = jpeg.Encode(buf, img, nil)
-	send_s3 := buf.Bytes()
-
-	tmpFile.Write(send_s3)
-
-	defer tmpFile.Close()
-
-	return tmpFile.Name()
-}

From 4fa1d67eeaa66f787e3659d17d0dc2ead91a26b5 Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sun, 21 May 2023 18:22:04 -0400
Subject: [PATCH 09/12] :art: Moving flag binding to config.go

Not the ideal place but gets the code out of main()
---
 config.go | 127 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 mt.go     | 125 -----------------------------------------------------
 2 files changed, 127 insertions(+), 125 deletions(-)

diff --git a/config.go b/config.go
index c441369..30050cd 100644
--- a/config.go
+++ b/config.go
@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"github.com/mitchellh/mapstructure"
 	log "github.com/sirupsen/logrus"
+	flag "github.com/spf13/pflag"
 	"github.com/spf13/viper"
 	"os"
 )
@@ -157,6 +158,132 @@ func configInit() {
 		log.Info("configuration file not found, using defaults")
 	}
 	log.Info("loaded config file")
+
+	// Bind values in config file to commandline flags
+	flag.IntP("numcaps", "n", viper.GetInt("numcaps"), "number of captures to make")
+	viper.BindPFlag("numcaps", flag.Lookup("numcaps"))
+
+	flag.IntP("columns", "c", viper.GetInt("columns"), "number of columns")
+	viper.BindPFlag("columns", flag.Lookup("columns"))
+
+	flag.IntP("padding", "p", viper.GetInt("padding"), "padding between the images in px")
+	viper.BindPFlag("padding", flag.Lookup("padding"))
+
+	flag.IntP("width", "w", viper.GetInt("width"), "width of a single screenshot in px")
+	viper.BindPFlag("width", flag.Lookup("width"))
+
+	flag.StringP("font", "f", viper.GetString("font_all"), "font to use for timestamps and header information")
+	viper.BindPFlag("font_all", flag.Lookup("font"))
+
+	flag.Int("font-size", viper.GetInt("font_size"), "font size in px")
+	viper.BindPFlag("font_size", flag.Lookup("font-size"))
+
+	flag.BoolP("disable-timestamps", "d", viper.GetBool("disable_timestamps"), "disable timestamps on images")
+	viper.BindPFlag("disable_timestamps", flag.Lookup("disable-timestamps"))
+
+	flag.BoolP("verbose", "v", viper.GetBool("verbose"), "enable verbose output")
+	viper.BindPFlag("verbose", flag.Lookup("verbose"))
+
+	flag.BoolP("single-images", "s", viper.GetBool("single_images"), "save single images instead of one combined contact sheet")
+	viper.BindPFlag("single_images", flag.Lookup("single-images"))
+
+	flag.String("bg-header", viper.GetString("bg_header"), "rgb background color for header")
+	viper.BindPFlag("bg_header", flag.Lookup("bg-header"))
+
+	flag.String("fg-header", viper.GetString("fg_header"), "rgb font color for header")
+	viper.BindPFlag("fg_header", flag.Lookup("fg-header"))
+
+	flag.String("bg-content", viper.GetString("bg_content"), "rgb background color for the main content area")
+	viper.BindPFlag("bg_content", flag.Lookup("bg-content"))
+
+	flag.String("header-image", viper.GetString("header_image"), "image to put in the header")
+	viper.BindPFlag("header_image", flag.Lookup("header-image"))
+
+	flag.String("comment", viper.GetString("comment"), "Add a text comment to the header")
+	viper.BindPFlag("comment", flag.Lookup("comment"))
+
+	flag.String("watermark", viper.GetString("watermark"), "watermark the final image")
+	viper.BindPFlag("watermark", flag.Lookup("watermark"))
+
+	flag.String("watermark-all", viper.GetString("watermark_all"), "watermark every single image")
+	viper.BindPFlag("watermark_all", flag.Lookup("watermark-all"))
+
+	flag.BoolP("skip-blank", "b", viper.GetBool("skip_blank"), "skip up to 3 images in a row which seem to be blank (can slow mt down)")
+	viper.BindPFlag("skip_blank", flag.Lookup("skip-blank"))
+
+	flag.Bool("skip-blurry", viper.GetBool("skip_blurry"), "skip up to 3 images in a row which seem to be blurry (can slow mt down)")
+	viper.BindPFlag("skip_blurry", flag.Lookup("skip-blurry"))
+
+	flag.Bool("version", false, "show version number and exit")
+	viper.BindPFlag("show_version", flag.Lookup("version"))
+
+	flag.Bool("header", viper.GetBool("header"), "append header to the contact sheet")
+	viper.BindPFlag("header", flag.Lookup("header"))
+
+	flag.Bool("header-meta", viper.GetBool("header_meta"), "also add codec, fps and bitrate informations to the header")
+	viper.BindPFlag("header_meta", flag.Lookup("header-meta"))
+
+	flag.String("filter", viper.GetString("filter"), "apply one or mor filters to images (comma seperated list), see --filters for available filters")
+	viper.BindPFlag("filter", flag.Lookup("filter"))
+
+	flag.Bool("filters", false, "list all available image filters")
+	viper.BindPFlag("filters", flag.Lookup("filters"))
+
+	flag.String("output", viper.GetString("filename"), "set an output filename")
+	viper.BindPFlag("filename", flag.Lookup("output"))
+
+	flag.String("from", viper.GetString("from"), "set starting point in format HH:MM:SS")
+	viper.BindPFlag("from", flag.Lookup("from"))
+
+	flag.String("to", viper.GetString("end"), "set end point in format HH:MM:SS")
+	viper.BindPFlag("end", flag.Lookup("to"))
+
+	flag.String("save-config", viper.GetString("save_config"), "save config with current settings to this file")
+	viper.BindPFlag("save_config", flag.Lookup("save-config"))
+
+	flag.String("config-file", viper.GetString("config_file"), "use a specific configuration file")
+	viper.BindPFlag("config_file", flag.Lookup("config-file"))
+
+	flag.Bool("skip-existing", viper.GetBool("skip_existing"), "skip any item if there is already a screencap present")
+	viper.BindPFlag("skip_existing", flag.Lookup("skip-existing"))
+
+	flag.Bool("overwrite", viper.GetBool("overwrite"), "overwrite existing screencaps")
+	viper.BindPFlag("overwrite", flag.Lookup("overwrite"))
+
+	flag.Bool("sfw", viper.GetBool("sfw"), "use nudity detection to generate sfw images (HIGHLY EXPERIMENTAL)")
+	viper.BindPFlag("sfw", flag.Lookup("sfw"))
+
+	flag.Bool("show-config", viper.GetBool("show_config"), "show path to currently used config file as well as used values and exit")
+	viper.BindPFlag("show_config", flag.Lookup("show-config"))
+
+	flag.Bool("fast", viper.GetBool("fast"), "inacurate but faster seeking")
+	viper.BindPFlag("fast", flag.Lookup("fast"))
+
+	flag.Bool("webvtt", viper.GetBool("webvtt"), "create a .vtt file: disables header, header-meta, padding and timestamps")
+	viper.BindPFlag("webvtt", flag.Lookup("webvtt"))
+
+	flag.Bool("vtt", viper.GetBool("vtt"), "create a .vtt file for the generated image")
+	viper.BindPFlag("vtt", flag.Lookup("vtt"))
+
+	flag.Int("blur-threshold", viper.GetInt("blur_threshold"), "set a custom threshold to use for blurry image detection (defaults to 62)")
+	viper.BindPFlag("blur_threshold", flag.Lookup("blur-threshold"))
+
+	flag.Int("blank-threshold", viper.GetInt("blank_threshold"), "set a custom threshold to use for blank image detection (defaults to 85)")
+	viper.BindPFlag("blank_threshold", flag.Lookup("blank-threshold"))
+
+	flag.Bool("upload", viper.GetBool("upload"), "post file via http form submit")
+	viper.BindPFlag("upload", flag.Lookup("upload"))
+
+	flag.String("upload-url", viper.GetString("upload_url"), "url to use for --upload")
+	viper.BindPFlag("upload_url", flag.Lookup("upload-url"))
+
+	flag.IntP("interval", "i", viper.GetInt("interval"), "interval in seconds to take screencaps from, overwrites numcaps (defaults to 0)")
+	viper.BindPFlag("interval", flag.Lookup("interval"))
+
+	flag.Bool("skip-credits", viper.GetBool("skip_credits"), "tries to skip ending credits from screencap creation by cutting off 4 minutes or 10 percent of the clip (defaults to false)")
+	viper.BindPFlag("skip_credits", flag.Lookup("skip-credits"))
+
+	flag.Parse()
 }
 
 func saveConfig(configurationPath string) error {
diff --git a/mt.go b/mt.go
index d188475..e2a55ec 100644
--- a/mt.go
+++ b/mt.go
@@ -558,136 +558,11 @@ func main() {
 
 	configInit()
 
-	flag.IntP("numcaps", "n", viper.GetInt("numcaps"), "number of captures to make")
-	viper.BindPFlag("numcaps", flag.Lookup("numcaps"))
-
-	flag.IntP("columns", "c", viper.GetInt("columns"), "number of columns")
-	viper.BindPFlag("columns", flag.Lookup("columns"))
-
-	flag.IntP("padding", "p", viper.GetInt("padding"), "padding between the images in px")
-	viper.BindPFlag("padding", flag.Lookup("padding"))
-
-	flag.IntP("width", "w", viper.GetInt("width"), "width of a single screenshot in px")
-	viper.BindPFlag("width", flag.Lookup("width"))
-
-	flag.StringP("font", "f", viper.GetString("font_all"), "font to use for timestamps and header information")
-	viper.BindPFlag("font_all", flag.Lookup("font"))
-
-	flag.Int("font-size", viper.GetInt("font_size"), "font size in px")
-	viper.BindPFlag("font_size", flag.Lookup("font-size"))
-
-	flag.BoolP("disable-timestamps", "d", viper.GetBool("disable_timestamps"), "disable timestamps on images")
-	viper.BindPFlag("disable_timestamps", flag.Lookup("disable-timestamps"))
-
-	flag.BoolP("verbose", "v", viper.GetBool("verbose"), "enable verbose output")
-	viper.BindPFlag("verbose", flag.Lookup("verbose"))
-
-	flag.BoolP("single-images", "s", viper.GetBool("single_images"), "save single images instead of one combined contact sheet")
-	viper.BindPFlag("single_images", flag.Lookup("single-images"))
-
-	flag.String("bg-header", viper.GetString("bg_header"), "rgb background color for header")
-	viper.BindPFlag("bg_header", flag.Lookup("bg-header"))
-
-	flag.String("fg-header", viper.GetString("fg_header"), "rgb font color for header")
-	viper.BindPFlag("fg_header", flag.Lookup("fg-header"))
-
-	flag.String("bg-content", viper.GetString("bg_content"), "rgb background color for the main content area")
-	viper.BindPFlag("bg_content", flag.Lookup("bg-content"))
-
-	flag.String("header-image", viper.GetString("header_image"), "image to put in the header")
-	viper.BindPFlag("header_image", flag.Lookup("header-image"))
-
-	flag.String("comment", viper.GetString("comment"), "Add a text comment to the header")
-	viper.BindPFlag("comment", flag.Lookup("comment"))
-
-	flag.String("watermark", viper.GetString("watermark"), "watermark the final image")
-	viper.BindPFlag("watermark", flag.Lookup("watermark"))
-
-	flag.String("watermark-all", viper.GetString("watermark_all"), "watermark every single image")
-	viper.BindPFlag("watermark_all", flag.Lookup("watermark-all"))
-
-	flag.BoolP("skip-blank", "b", viper.GetBool("skip_blank"), "skip up to 3 images in a row which seem to be blank (can slow mt down)")
-	viper.BindPFlag("skip_blank", flag.Lookup("skip-blank"))
-
-	flag.Bool("skip-blurry", viper.GetBool("skip_blurry"), "skip up to 3 images in a row which seem to be blurry (can slow mt down)")
-	viper.BindPFlag("skip_blurry", flag.Lookup("skip-blurry"))
-
-	flag.Bool("version", false, "show version number and exit")
-	viper.BindPFlag("show_version", flag.Lookup("version"))
-
-	flag.Bool("header", viper.GetBool("header"), "append header to the contact sheet")
-	viper.BindPFlag("header", flag.Lookup("header"))
-
-	flag.Bool("header-meta", viper.GetBool("header_meta"), "also add codec, fps and bitrate informations to the header")
-	viper.BindPFlag("header_meta", flag.Lookup("header-meta"))
-
-	flag.String("filter", viper.GetString("filter"), "apply one or mor filters to images (comma seperated list), see --filters for available filters")
-	viper.BindPFlag("filter", flag.Lookup("filter"))
-
-	flag.Bool("filters", false, "list all available image filters")
-	viper.BindPFlag("filters", flag.Lookup("filters"))
-
-	flag.String("output", viper.GetString("filename"), "set an output filename")
-	viper.BindPFlag("filename", flag.Lookup("output"))
-
-	flag.String("from", viper.GetString("from"), "set starting point in format HH:MM:SS")
-	viper.BindPFlag("from", flag.Lookup("from"))
-
-	flag.String("to", viper.GetString("end"), "set end point in format HH:MM:SS")
-	viper.BindPFlag("end", flag.Lookup("to"))
-
-	flag.String("save-config", viper.GetString("save_config"), "save config with current settings to this file")
-	viper.BindPFlag("save_config", flag.Lookup("save-config"))
-
-	flag.String("config-file", viper.GetString("config_file"), "use a specific configuration file")
-	viper.BindPFlag("config_file", flag.Lookup("config-file"))
-
-	flag.Bool("skip-existing", viper.GetBool("skip_existing"), "skip any item if there is already a screencap present")
-	viper.BindPFlag("skip_existing", flag.Lookup("skip-existing"))
-
-	flag.Bool("overwrite", viper.GetBool("overwrite"), "overwrite existing screencaps")
-	viper.BindPFlag("overwrite", flag.Lookup("overwrite"))
-
-	flag.Bool("sfw", viper.GetBool("sfw"), "use nudity detection to generate sfw images (HIGHLY EXPERIMENTAL)")
-	viper.BindPFlag("sfw", flag.Lookup("sfw"))
-
-	flag.Bool("show-config", viper.GetBool("show_config"), "show path to currently used config file as well as used values and exit")
-	viper.BindPFlag("show_config", flag.Lookup("show-config"))
-
-	flag.Bool("fast", viper.GetBool("fast"), "inacurate but faster seeking")
-	viper.BindPFlag("fast", flag.Lookup("fast"))
-
-	flag.Bool("webvtt", viper.GetBool("webvtt"), "create a .vtt file: disables header, header-meta, padding and timestamps")
-	viper.BindPFlag("webvtt", flag.Lookup("webvtt"))
-
-	flag.Bool("vtt", viper.GetBool("vtt"), "create a .vtt file for the generated image")
-	viper.BindPFlag("vtt", flag.Lookup("vtt"))
-
-	flag.Int("blur-threshold", viper.GetInt("blur_threshold"), "set a custom threshold to use for blurry image detection (defaults to 62)")
-	viper.BindPFlag("blur_threshold", flag.Lookup("blur-threshold"))
-
-	flag.Int("blank-threshold", viper.GetInt("blank_threshold"), "set a custom threshold to use for blank image detection (defaults to 85)")
-	viper.BindPFlag("blank_threshold", flag.Lookup("blank-threshold"))
-
-	flag.Bool("upload", viper.GetBool("upload"), "post file via http form submit")
-	viper.BindPFlag("upload", flag.Lookup("upload"))
-
-	flag.String("upload-url", viper.GetString("upload_url"), "url to use for --upload")
-	viper.BindPFlag("upload_url", flag.Lookup("upload-url"))
-
-	flag.IntP("interval", "i", viper.GetInt("interval"), "interval in seconds to take screencaps from, overwrites numcaps (defaults to 0)")
-	viper.BindPFlag("interval", flag.Lookup("interval"))
-
-	flag.Bool("skip-credits", viper.GetBool("skip_credits"), "tries to skip ending credits from screencap creation by cutting off 4 minutes or 10 percent of the clip (defaults to false)")
-	viper.BindPFlag("skip_credits", flag.Lookup("skip-credits"))
-
 	flag.Usage = func() {
 		fmt.Fprintf(os.Stderr, "Usage of %s: [flags] [file]\n", os.Args[0])
 		flag.PrintDefaults()
 	}
 
-	flag.Parse()
-
 	if viper.GetBool("show_version") {
 		fmt.Fprintf(os.Stderr, "mt Version %s\n", version)
 		os.Exit(1)

From 7858a100c59e4dd09da0253c3a71fb3230bf0ff8 Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sun, 21 May 2023 18:46:00 -0400
Subject: [PATCH 10/12] :goal_net: Added error handling for flags

---
 config.go | 130 +++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 89 insertions(+), 41 deletions(-)

diff --git a/config.go b/config.go
index 30050cd..36097b2 100644
--- a/config.go
+++ b/config.go
@@ -160,128 +160,170 @@ func configInit() {
 	log.Info("loaded config file")
 
 	// Bind values in config file to commandline flags
+	var bindErr error
 	flag.IntP("numcaps", "n", viper.GetInt("numcaps"), "number of captures to make")
-	viper.BindPFlag("numcaps", flag.Lookup("numcaps"))
+	bindErr = viper.BindPFlag("numcaps", flag.Lookup("numcaps"))
+	flagBindErrorHandling(bindErr)
 
 	flag.IntP("columns", "c", viper.GetInt("columns"), "number of columns")
-	viper.BindPFlag("columns", flag.Lookup("columns"))
+	bindErr = viper.BindPFlag("columns", flag.Lookup("columns"))
+	flagBindErrorHandling(bindErr)
 
 	flag.IntP("padding", "p", viper.GetInt("padding"), "padding between the images in px")
-	viper.BindPFlag("padding", flag.Lookup("padding"))
+	bindErr = viper.BindPFlag("padding", flag.Lookup("padding"))
+	flagBindErrorHandling(bindErr)
 
 	flag.IntP("width", "w", viper.GetInt("width"), "width of a single screenshot in px")
-	viper.BindPFlag("width", flag.Lookup("width"))
+	bindErr = viper.BindPFlag("width", flag.Lookup("width"))
+	flagBindErrorHandling(bindErr)
 
 	flag.StringP("font", "f", viper.GetString("font_all"), "font to use for timestamps and header information")
-	viper.BindPFlag("font_all", flag.Lookup("font"))
+	bindErr = viper.BindPFlag("font_all", flag.Lookup("font"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Int("font-size", viper.GetInt("font_size"), "font size in px")
-	viper.BindPFlag("font_size", flag.Lookup("font-size"))
+	bindErr = viper.BindPFlag("font_size", flag.Lookup("font-size"))
+	flagBindErrorHandling(bindErr)
 
 	flag.BoolP("disable-timestamps", "d", viper.GetBool("disable_timestamps"), "disable timestamps on images")
-	viper.BindPFlag("disable_timestamps", flag.Lookup("disable-timestamps"))
+	bindErr = viper.BindPFlag("disable_timestamps", flag.Lookup("disable-timestamps"))
+	flagBindErrorHandling(bindErr)
 
 	flag.BoolP("verbose", "v", viper.GetBool("verbose"), "enable verbose output")
-	viper.BindPFlag("verbose", flag.Lookup("verbose"))
+	bindErr = viper.BindPFlag("verbose", flag.Lookup("verbose"))
+	flagBindErrorHandling(bindErr)
 
 	flag.BoolP("single-images", "s", viper.GetBool("single_images"), "save single images instead of one combined contact sheet")
-	viper.BindPFlag("single_images", flag.Lookup("single-images"))
+	bindErr = viper.BindPFlag("single_images", flag.Lookup("single-images"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("bg-header", viper.GetString("bg_header"), "rgb background color for header")
-	viper.BindPFlag("bg_header", flag.Lookup("bg-header"))
+	bindErr = viper.BindPFlag("bg_header", flag.Lookup("bg-header"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("fg-header", viper.GetString("fg_header"), "rgb font color for header")
-	viper.BindPFlag("fg_header", flag.Lookup("fg-header"))
+	bindErr = viper.BindPFlag("fg_header", flag.Lookup("fg-header"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("bg-content", viper.GetString("bg_content"), "rgb background color for the main content area")
-	viper.BindPFlag("bg_content", flag.Lookup("bg-content"))
+	bindErr = viper.BindPFlag("bg_content", flag.Lookup("bg-content"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("header-image", viper.GetString("header_image"), "image to put in the header")
-	viper.BindPFlag("header_image", flag.Lookup("header-image"))
+	bindErr = viper.BindPFlag("header_image", flag.Lookup("header-image"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("comment", viper.GetString("comment"), "Add a text comment to the header")
-	viper.BindPFlag("comment", flag.Lookup("comment"))
+	bindErr = viper.BindPFlag("comment", flag.Lookup("comment"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("watermark", viper.GetString("watermark"), "watermark the final image")
-	viper.BindPFlag("watermark", flag.Lookup("watermark"))
+	bindErr = viper.BindPFlag("watermark", flag.Lookup("watermark"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("watermark-all", viper.GetString("watermark_all"), "watermark every single image")
-	viper.BindPFlag("watermark_all", flag.Lookup("watermark-all"))
+	bindErr = viper.BindPFlag("watermark_all", flag.Lookup("watermark-all"))
+	flagBindErrorHandling(bindErr)
 
 	flag.BoolP("skip-blank", "b", viper.GetBool("skip_blank"), "skip up to 3 images in a row which seem to be blank (can slow mt down)")
-	viper.BindPFlag("skip_blank", flag.Lookup("skip-blank"))
+	bindErr = viper.BindPFlag("skip_blank", flag.Lookup("skip-blank"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("skip-blurry", viper.GetBool("skip_blurry"), "skip up to 3 images in a row which seem to be blurry (can slow mt down)")
-	viper.BindPFlag("skip_blurry", flag.Lookup("skip-blurry"))
+	bindErr = viper.BindPFlag("skip_blurry", flag.Lookup("skip-blurry"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("version", false, "show version number and exit")
-	viper.BindPFlag("show_version", flag.Lookup("version"))
+	bindErr = viper.BindPFlag("show_version", flag.Lookup("version"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("header", viper.GetBool("header"), "append header to the contact sheet")
-	viper.BindPFlag("header", flag.Lookup("header"))
+	bindErr = viper.BindPFlag("header", flag.Lookup("header"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("header-meta", viper.GetBool("header_meta"), "also add codec, fps and bitrate informations to the header")
-	viper.BindPFlag("header_meta", flag.Lookup("header-meta"))
+	bindErr = viper.BindPFlag("header_meta", flag.Lookup("header-meta"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("filter", viper.GetString("filter"), "apply one or mor filters to images (comma seperated list), see --filters for available filters")
-	viper.BindPFlag("filter", flag.Lookup("filter"))
+	bindErr = viper.BindPFlag("filter", flag.Lookup("filter"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("filters", false, "list all available image filters")
-	viper.BindPFlag("filters", flag.Lookup("filters"))
+	bindErr = viper.BindPFlag("filters", flag.Lookup("filters"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("output", viper.GetString("filename"), "set an output filename")
-	viper.BindPFlag("filename", flag.Lookup("output"))
+	bindErr = viper.BindPFlag("filename", flag.Lookup("output"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("from", viper.GetString("from"), "set starting point in format HH:MM:SS")
-	viper.BindPFlag("from", flag.Lookup("from"))
+	bindErr = viper.BindPFlag("from", flag.Lookup("from"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("to", viper.GetString("end"), "set end point in format HH:MM:SS")
-	viper.BindPFlag("end", flag.Lookup("to"))
+	bindErr = viper.BindPFlag("end", flag.Lookup("to"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("save-config", viper.GetString("save_config"), "save config with current settings to this file")
-	viper.BindPFlag("save_config", flag.Lookup("save-config"))
+	bindErr = viper.BindPFlag("save_config", flag.Lookup("save-config"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("config-file", viper.GetString("config_file"), "use a specific configuration file")
-	viper.BindPFlag("config_file", flag.Lookup("config-file"))
+	bindErr = viper.BindPFlag("config_file", flag.Lookup("config-file"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("skip-existing", viper.GetBool("skip_existing"), "skip any item if there is already a screencap present")
-	viper.BindPFlag("skip_existing", flag.Lookup("skip-existing"))
+	bindErr = viper.BindPFlag("skip_existing", flag.Lookup("skip-existing"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("overwrite", viper.GetBool("overwrite"), "overwrite existing screencaps")
-	viper.BindPFlag("overwrite", flag.Lookup("overwrite"))
+	bindErr = viper.BindPFlag("overwrite", flag.Lookup("overwrite"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("sfw", viper.GetBool("sfw"), "use nudity detection to generate sfw images (HIGHLY EXPERIMENTAL)")
-	viper.BindPFlag("sfw", flag.Lookup("sfw"))
+	bindErr = viper.BindPFlag("sfw", flag.Lookup("sfw"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("show-config", viper.GetBool("show_config"), "show path to currently used config file as well as used values and exit")
-	viper.BindPFlag("show_config", flag.Lookup("show-config"))
+	bindErr = viper.BindPFlag("show_config", flag.Lookup("show-config"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("fast", viper.GetBool("fast"), "inacurate but faster seeking")
-	viper.BindPFlag("fast", flag.Lookup("fast"))
+	bindErr = viper.BindPFlag("fast", flag.Lookup("fast"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("webvtt", viper.GetBool("webvtt"), "create a .vtt file: disables header, header-meta, padding and timestamps")
-	viper.BindPFlag("webvtt", flag.Lookup("webvtt"))
+	bindErr = viper.BindPFlag("webvtt", flag.Lookup("webvtt"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("vtt", viper.GetBool("vtt"), "create a .vtt file for the generated image")
-	viper.BindPFlag("vtt", flag.Lookup("vtt"))
+	bindErr = viper.BindPFlag("vtt", flag.Lookup("vtt"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Int("blur-threshold", viper.GetInt("blur_threshold"), "set a custom threshold to use for blurry image detection (defaults to 62)")
-	viper.BindPFlag("blur_threshold", flag.Lookup("blur-threshold"))
+	bindErr = viper.BindPFlag("blur_threshold", flag.Lookup("blur-threshold"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Int("blank-threshold", viper.GetInt("blank_threshold"), "set a custom threshold to use for blank image detection (defaults to 85)")
-	viper.BindPFlag("blank_threshold", flag.Lookup("blank-threshold"))
+	bindErr = viper.BindPFlag("blank_threshold", flag.Lookup("blank-threshold"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("upload", viper.GetBool("upload"), "post file via http form submit")
-	viper.BindPFlag("upload", flag.Lookup("upload"))
+	bindErr = viper.BindPFlag("upload", flag.Lookup("upload"))
+	flagBindErrorHandling(bindErr)
 
 	flag.String("upload-url", viper.GetString("upload_url"), "url to use for --upload")
-	viper.BindPFlag("upload_url", flag.Lookup("upload-url"))
+	bindErr = viper.BindPFlag("upload_url", flag.Lookup("upload-url"))
+	flagBindErrorHandling(bindErr)
 
 	flag.IntP("interval", "i", viper.GetInt("interval"), "interval in seconds to take screencaps from, overwrites numcaps (defaults to 0)")
-	viper.BindPFlag("interval", flag.Lookup("interval"))
+	bindErr = viper.BindPFlag("interval", flag.Lookup("interval"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Bool("skip-credits", viper.GetBool("skip_credits"), "tries to skip ending credits from screencap creation by cutting off 4 minutes or 10 percent of the clip (defaults to false)")
-	viper.BindPFlag("skip_credits", flag.Lookup("skip-credits"))
+	bindErr = viper.BindPFlag("skip_credits", flag.Lookup("skip-credits"))
+	flagBindErrorHandling(bindErr)
 
 	flag.Parse()
 }
@@ -311,3 +353,9 @@ func saveConfig(configurationPath string) error {
 
 	return nil
 }
+
+func flagBindErrorHandling(e error) {
+	if e != nil {
+		panic(e)
+	}
+}

From 41cebf2ceac3d32b2b2b2529d74879275b27896f Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sun, 21 May 2023 19:36:38 -0400
Subject: [PATCH 11/12] :goal_net: Added error handling for file operations

---
 config.go | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/config.go b/config.go
index 36097b2..bb203db 100644
--- a/config.go
+++ b/config.go
@@ -331,7 +331,6 @@ func configInit() {
 func saveConfig(configurationPath string) error {
 	var currentConfig config
 	err := mapstructure.WeakDecode(viper.AllSettings(), &currentConfig)
-
 	if err != nil {
 		return err
 	}
@@ -343,15 +342,19 @@ func saveConfig(configurationPath string) error {
 
 	f, err := os.Create(configurationPath)
 	if err != nil {
-		return ErrCannotSaveConfigFile
+		return err
 	}
 
-	defer f.Close()
+	_, err = f.WriteString(string(b))
+	if err != nil {
+		if err := f.Close(); err != nil {
+			return err
+		}
+		return ErrCannotSaveConfigFile
+	}
 
-	f.WriteString(string(b))
 	log.Infof("config file saved to: %s", configurationPath)
-
-	return nil
+	return f.Close()
 }
 
 func flagBindErrorHandling(e error) {

From d2f401ef20b71552a9129fabaf4434afa77992f0 Mon Sep 17 00:00:00 2001
From: Glottal Trill <philmslim@protonmail.com>
Date: Sun, 21 May 2023 19:39:00 -0400
Subject: [PATCH 12/12] :fire: Removing notes

---
 mt.go | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/mt.go b/mt.go
index e2a55ec..e967f68 100644
--- a/mt.go
+++ b/mt.go
@@ -654,11 +654,6 @@ NOTE: fancy has best results if it is applied as last filter!
 		os.Exit(1)
 	}
 
-	//
-	//
-	//
-	// End of main()
-
 	for _, movie := range flag.Args() {
 		mpath = movie
 		log.Infof("generating contact sheet for %s", movie)