Random continuous searches

[HorusApl]

Describe the bug
Seemingly at random, when a player searches for any item it will just continuously search on their side and pull up nothing. Console says it is completed in X ms like normal, but nothing appears for the player. Issue has begun on the latest release, on 1.21.4 Purpur

To Reproduce
Unsure of how to reproduce, issue is very sporadic. Hundreds of commands might make it happen a handful of times.

Expected behavior
Menu appears normally when searched, or a message given saying no items found.

Quickshop Hikari / Reremake and version:
6.2.0.8
QSFinditemAddOn version:
2.0.7.3-RELEASE

[myzticbean]

You can try this build and let me know if you face it again: https://github.com/myzticbean/QSFindItemAddOn/releases/tag/2.0.7.4

[HorusApl]

@myzticbean It was fine for awhile, but recently the search doesn't work at all. Getting this error:

[07:24:04 INFO]: Catx_ issued server command: /shopsearch sell stone
[07:24:04 WARN]: [QSFindItemAddOn] Plugin QSFindItemAddOn v2.0.7.6-RELEASE generated an exception while executing task 12106208
java.lang.NullPointerException: Cannot invoke "io.myzticbean.finditemaddon.dependencies.BentoBoxPlugin.isIslandLocked(org.bukkit.Location, org.bukkit.entity.Player)" because the return value of "io.myzticbean.finditemaddon.FindItemAddOn.getBentoboxPlugin()" is null
at QSFindItemAddOn-2.0.7.6-RELEASE (2).jar/io.myzticbean.finditemaddon.quickshop.impl.QSHikariAPIHandler.processPotentialShopMatchAndAddToFoundList(QSHikariAPIHandler.java:462) ~[QSFindItemAddOn-2.0.7.6-RELEASE (2).jar:?]
at QSFindItemAddOn-2.0.7.6-RELEASE (2).jar/io.myzticbean.finditemaddon.quickshop.impl.QSHikariAPIHandler.findItemBasedOnTypeFromAllShops(QSHikariAPIHandler.java:99) ~[QSFindItemAddOn-2.0.7.6-RELEASE (2).jar:?]
at QSFindItemAddOn-2.0.7.6-RELEASE (2).jar/io.myzticbean.finditemaddon.handlers.command.CmdExecutorHandler.lambda$handleShopSearch$1(CmdExecutorHandler.java:104) ~[QSFindItemAddOn-2.0.7.6-RELEASE (2).jar:?]
at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[purpur-1.21.8.jar:1.21.8-2496-59fb18d]
at org.bukkit.craftbukkit.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[purpur-1.21.8.jar:1.21.8-2496-59fb18d]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[purpur-1.21.8.jar:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

And currently using 2.0.7.6

[myzticbean]

Okay I'll have a look.

[myzticbean]

@HorusApl Try out this build: https://github.com/myzticbean/QSFindItemAddOn/releases/tag/2.0.7.7

[HorusApl]

@myzticbean Still appears fully broken no matter what item is searched, it will always just stick at "Searching..." forever. The console error appears to be gone, but the commands aren't

[myzticbean]

@myzticbean Still appears fully broken no matter what item is searched, it will always just stick at "Searching..." forever. The console error appears to be gone, but the commands aren't

@HorusApl I suggest you to enable debug mode from config.yml and search shop, and share the console log that you get. Hopefully I can get some more insight on the issue.
Btw, related to ur previously shared log, do you use the bentobox plugin?

[HorusApl]

[07:04:38 INFO]: Catx_ issued server command: /shopsearch buy stone
[07:04:38 WARN]: [QuickShop-FindItemAddOn-DEBUG] [MAIN] Material found: STONE
[07:04:38 WARN]: [QuickShop-FindItemAddOn-DEBUG] [ASYNC] Is MAIN Thread? false
[07:04:38 WARN]: [QuickShop-FindItemAddOn-DEBUG] [ASYNC] Total shops on server: 7359
[07:04:39 INFO]: Catx_ issued server command: /shopsearch sell stone
[07:04:39 WARN]: [QuickShop-FindItemAddOn-DEBUG] [MAIN] Material found: STONE
[07:04:39 WARN]: [QuickShop-FindItemAddOn-DEBUG] [ASYNC] Is MAIN Thread? false
[07:04:39 WARN]: [QuickShop-FindItemAddOn-DEBUG] [ASYNC] Total shops on server: 7359
[07:04:39 WARN]: [QuickShop-FindItemAddOn-DEBUG] [ASYNC] Shop match found: Location{world=CraftWorld{name=world},x=-16561.0,y=70.0,z=7180.0,pitch=0.0,yaw=0.0}

Here is the output

[thanthal1]

I had the same issue. Its caused by a bentobox plugin reference.
Added a null check
if (FindItemAddOn.getBentoboxPlugin() != null && FindItemAddOn.getBentoboxPlugin().isIslandLocked(...)) return;
Forgot to make subbranch but too lazy to fix Forked fix