Commit 566d7eb
authored
chore(iroh, iroh-relay): Avoid a duplicate tungstenite dependency (#3006)
## Description
Before we used to depend on both tungstenite version 0.21 as well as
0.24, because:
```
tungstenite v0.21.0
└── tokio-tungstenite v0.21.0
└── tokio-tungstenite-wasm v0.3.1
├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
└── iroh-relay v0.29.0 (/home/philipp/program/work/iroh/iroh-relay)
├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
└── iroh-net-report v0.29.0 (/home/philipp/program/work/iroh/iroh-net-report)
└── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
tungstenite v0.24.0
└── tokio-tungstenite v0.24.0
├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
└── iroh-relay v0.29.0 (/home/philipp/program/work/iroh/iroh-relay)
├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
└── iroh-net-report v0.29.0 (/home/philipp/program/work/iroh/iroh-net-report)
└── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
```
Basically, `tokio-tungstenite-wasm` pulls in `0.21` and there's no newer
version of it yet.
But we updated all our dependencies including `tungstenite`, duplicating
it.
## Notes & open questions
<!-- Any notes, remarks or open questions you have to make about the PR.
-->
I want this to be temporary until we can finally switch to
`fasterwebsockets` entirely once it implements [`poll`-based
methods](denoland/fastwebsockets#78) (but I
worry the project's maintenance is ... unclear).
I checked the [tungstenite
changelog](https://github.com/snapview/tungstenite-rs/blob/master/CHANGELOG.md),
and it doesn't look like there's anything critical in there. The
`rustls` update doesn't affect us - we don't duplicate rustls versions
after this rollback.
## Change checklist
- [x] Self-review.
- [x] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- ~~[ ] Tests if relevant.~~
- [x] All breaking changes documented.1 parent f75a04b commit 566d7eb
3 files changed
+6
-36
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
0 commit comments