Skip to content

Consider Managed Parameter API change #407

@dccutrig

Description

@dccutrig

Consider the following TM specific Managed Parameters:

     GvcidManagedParameters_t TM_UT_Managed_Parameters = {
         0, 0x002c, 0, TM_NO_FECF, AOS_FHEC_NA, AOS_IZ_NA, 0, TM_SEGMENT_HDRS_NA, 1024, TM_NO_OCF, 1};
     Crypto_Config_Add_Gvcid_Managed_Parameters(TM_UT_Managed_Parameters);

There are several arguments that don't apply to TM, which I feel complicates setup for folks and propose the following:

TMGvcidManagedParameters_t TM_UT_Managed_Parameters = {
         0, 0x002c, 0, TM_NO_FECF, TM_SEGMENT_HDRS_NA, 1024, TM_NO_OCF, 1};
     Crypto_Config_Add_TM_Gvcid_Managed_Parameters(TM_UT_Managed_Parameters);

With under the hood the following happening:

 Crypto_Config_Add_TM_Gvcid_Managed_Parameters(TM_UT_Managed_Parameters * params)
{
    GvcidManagedParameters_t fullParams = {params.tfvn, params.scid, AOS_FHEC_NA, AOS_IZ_NA, 0, params.has_segmentation_hdr, params.max_frame_size, params.has_ocf, params.set_flag);

     Crypto_Config_Add_Gvcid_Managed_Parameters(fullParams);
}

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions