Renaming generated functions to match SerializeBufferBase refactor. Also renamed SerializeBufferBase to LinearBufferBase. #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincewoo
changed the title
|
@bocchino I have made the change that you requested to change SerializeBufferBase to LinearBufferBase. This was accomplished through a global search-and-replace. |
|
@vincewoo What is the status of this PR? It looks like CI is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializeBufferBase refactor proposed in the following PR: nasa/fprime#4288
This change updated the FPP generated classes to adhere to the new naming scheme. We have also renamed SerializeBufferBase into LinearBufferBase.
Tested locally with fprime. Generates, builds, and UTs all run cleanly.