Skip to content

Commit ee88ef3

Browse files
Merge branch 'main' into integration-of-wandb-entity
2 parents f58d949 + 54b127f commit ee88ef3

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

.github/workflows/core_code_checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
uses: actions/setup-python@v4
2020
with:
2121
python-version: '3.8.13'
22-
- uses: actions/cache@v2
22+
- uses: actions/cache@v3
2323
with:
2424
path: ${{ env.pythonLocation }}
2525
key: ${{ env.pythonLocation }}-${{ hashFiles('pyproject.toml') }}

nerfstudio/scripts/exporter.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -288,12 +288,6 @@ class ExportPoissonMesh(Exporter):
288288
"""Name of the normal output."""
289289
save_point_cloud: bool = False
290290
"""Whether to save the point cloud."""
291-
use_bounding_box: bool = True
292-
"""Only query points within the bounding box"""
293-
bounding_box_min: Tuple[float, float, float] = (-1, -1, -1)
294-
"""Minimum of the bounding box, used if use_bounding_box is True."""
295-
bounding_box_max: Tuple[float, float, float] = (1, 1, 1)
296-
"""Minimum of the bounding box, used if use_bounding_box is True."""
297291
obb_center: Optional[Tuple[float, float, float]] = None
298292
"""Center of the oriented bounding box."""
299293
obb_rotation: Optional[Tuple[float, float, float]] = None

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies = [
3636
"opencv-python-headless==4.10.0.84",
3737
"Pillow>=10.3.0",
3838
"plotly>=5.7.0",
39-
"protobuf<=3.20.3,!=3.20.0",
39+
"protobuf<=5,!=3.20.0",
4040
# TODO(1480) enable when pycolmap windows wheels are available
4141
# "pycolmap==0.3.0",
4242
# TODO(3461) and external issue cnr-isti-vclab/PyMeshLab/issues/398: Unrestrict Windows version when it isn't broken anymore.

0 commit comments

Comments
 (0)