php-fpm collector makes no sense

[withinboredom]

I couldn't get the php-fpm collector to be discovered, even after updating it to use php-fpm ports (9000/9001 depending on whether or not stats is in it's own pool). It was then that I noticed this in the docs for it:

access to status page via web server.

-- https://learn.netdata.cloud/docs/agent/collectors/go.d.plugin/modules/phpfpm

In containers, it's unlikely that a php-fpm container would also have a webserver installed and running on it. Instead the collector should connect to php-fpm directly on port 9000 or 9001 by default and use the fast-cgi API to request stats instead of HTTP. This doesn't appear to work atm.

Edit to add:

nginx ingress allows connecting directly to php-fpm via fast-cgi, so there is no need to run a webserver in the pod. Adding a webserver to the pod just to collect stats seems like overkill.

[ilyam8]

Hi, @withinboredom. I see php-fpm collector supports collecting metrics via HTTP and Unix socket. The 2nd option uses fast-cgi client. Not a specialist, I don't know if it is possible to use fast-cgi client when querying over the network - if yes, we need to implement that.