From 32280c647f31c4ae215ed2056b704419d4696707 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Thu, 30 Oct 2025 15:57:57 -0400 Subject: [PATCH 1/4] ci: update deno version used in workflows --- .github/workflows/workflow.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index fc9583fc50..48c647e80d 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -54,14 +54,12 @@ jobs: os: [ubuntu-24.04, macos-14, windows-2025] node-version: ['22'] # Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`. - # We're adding v2.4.2 here because it's needed for the upcoming nimble release, so we can test - # those workflows ahead of time before we can update the base version across the board. - deno-version: ['v1.39.0', 'v2.2.4', 'v2.4.2'] + deno-version: ['v2.4.2'] include: - os: ubuntu-24.04 # Earliest supported version node-version: '18.14.0' - deno-version: 'v2.2.4' + deno-version: 'v2.4.2' fail-fast: false steps: # Sets an output parameter if this is a release PR @@ -159,7 +157,7 @@ jobs: - name: Setup Deno uses: denoland/setup-deno@v1 with: - deno-version: v2.2.4 + deno-version: v2.4.2 if: ${{ !steps.release-check.outputs.IS_RELEASE }} - name: Node.js ${{ matrix.node-version }} uses: actions/setup-node@v6 From 543ebd1a13fad6c3432250f3e4a829a348f2306f Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Thu, 30 Oct 2025 15:58:14 -0400 Subject: [PATCH 2/4] fix: update edge_bundler_deno_v2 default value --- packages/edge-bundler/node/feature_flags.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edge-bundler/node/feature_flags.ts b/packages/edge-bundler/node/feature_flags.ts index 3a35c11dac..0ac0ee16e0 100644 --- a/packages/edge-bundler/node/feature_flags.ts +++ b/packages/edge-bundler/node/feature_flags.ts @@ -1,7 +1,7 @@ const defaultFlags = { edge_bundler_generate_tarball: false, edge_bundler_dry_run_generate_tarball: false, - edge_bundler_deno_v2: false, + edge_bundler_deno_v2: true, } type FeatureFlag = keyof typeof defaultFlags From 88ba7c2497a9df444f93f63ed305e3241838a903 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Thu, 30 Oct 2025 16:26:11 -0400 Subject: [PATCH 3/4] test: update snapshots --- .../edge_functions/snapshots/tests.js.md | 8 ++++---- .../edge_functions/snapshots/tests.js.snap | Bin 3154 -> 3155 bytes 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/build/tests/edge_functions/snapshots/tests.js.md b/packages/build/tests/edge_functions/snapshots/tests.js.md index a57e5e46ea..dd91154bf1 100644 --- a/packages/build/tests/edge_functions/snapshots/tests.js.md +++ b/packages/build/tests/edge_functions/snapshots/tests.js.md @@ -1279,7 +1279,7 @@ Generated by [AVA](https://avajs.dev). ────────────────────────────────────────────────────────────────␊ ␊ Error message␊ - Error: Command failed with exit code 1: "/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts␊ + Error: Command failed with exit code 1: deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts␊ STACK TRACE␊ ␊ export async () => ␊ @@ -1292,9 +1292,9 @@ Generated by [AVA](https://avajs.dev). ␊ Error properties␊ {␊ - shortMessage: 'Command failed with exit code 1: "/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊ - command: '"/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊ - escapedCommand: '"/external/path" bundle --import-map "BASE64_STRING" --quiet --code-splitting --allow-import --outdir "/external/path" "packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts"',␊ + shortMessage: 'Command failed with exit code 1: deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊ + command: 'deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊ + escapedCommand: 'deno bundle --import-map "BASE64_STRING" --quiet --code-splitting --allow-import --outdir "/external/path" "packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts"',␊ exitCode: 1,␊ signal: undefined,␊ signalDescription: undefined,␊ diff --git a/packages/build/tests/edge_functions/snapshots/tests.js.snap b/packages/build/tests/edge_functions/snapshots/tests.js.snap index a725462cd164e7acb16c3eafda8620c576440e1c..0b7962688422fa850000a14aa9dd150e48b105e6 100644 GIT binary patch literal 3155 zcmV-Z46O4(RzVi`WEF#ukl_8O70I(OZSN)_pkC!N@yv!%CbO%Z zSpo_hr>47X*KT)JQ&l||R*T>f1P@3&1O*|2gpiPUL;N0;KY)148>sqXyM5Uyd)i}< z_l#O2O}o2#`a7q-?^JcUzt1{Hq3|E6PhS2D)l7%<^tFI?ND^vr!53UM!W`e6`hn?y~ zQq@$_Z|5OP+Y`LQy3k=Ey+BLN{4N?=L}A{nrl;C8DMgT^r<(nHf&`3rAr6x+`^X>HRp(8~Ej5mPEb%)8GfKzFusOlC zmCNs1$mRC#!Qr`!m;PST!B25IY`N26v1DAg1Ewyzc4^QMPKGTwVH%T1RBj4BPL5gQ zSmo2^l>4&hG*hW>WLgZV52+8SZ?=SK(o;<(Ct=e(Z9}fJ2F{l2-WqUSn)+(A_D-`> z_b4QaN;h9aJLrTHXzw2-+WQmI-g0TLzpHH`ctPqbH)ctH&-{q?ZVIuv3EyfuYh z4O}SpyEk#bI}`S{M0m@Z2pP{L>8T`$wcltUR)hqL=#3NMzA)u}u>($sf?V!ANYd2^ zrMV8(K*pOI?58u{lmRVLUNzv`Qr;aa$~zLe*DnBp@L)0tGO8xf;D1Uq_-~}aRiQx> zOyt5#iFl=4_zG5&%Z%k5--zrH9)wguhp;e_6i#}S4?r%1KVcogpGyq-J6uPwDh$f_ zF$q~v*?>B4569GYSx_MhDno=fP=FmNg@lMIMY<-DsrlQ3 z``jlZoE*g1`< zZ|JiAxV{Npp`lLH8TaczG>p#m8eHjVETo3?AlSGLZ@dY$A=rOze)>DohczInhBtuI zlk8vI=u&;4CF9-OQbZpR72Vh%vU_6_i0t0He*IQ$QanGZ9UN}8-h;z?Tdkb|Hlgr| z&Y0(eo+*s_{jQWU=7f7xiSU>Pc^y@Qtj6}T+bXevR}p25uDCQ;ij$*|soq5|G2GT2 z$-0btMFluvNqLG29UD#@GXgTY zr%KVQO5m4KJ`G=Z5w%ku(`kiM4F)5S?7p0DJ6>Ln29%37i%j*~j!3+Sdu(RSyAg>S z4^_5K1$A>GUsS7`d%`Cn9A^w<#+&*qrpoYl61!Ts0nyZhAME^SYkQ})`~KEmdw08b zKb>{$hT@2Xz|5+&FigiHrh#qB1+?~dEsxq4z_{BVtz~^UU0&T0a%A*NG}IT6djmKc zTGdB0tWZ1;9y|G9!tp+Q>=31>c08wyO@peRvDn#kIzmRoe4g%j#d-2z(~%<4`Ps!a z9nTqD-r00wqRqh5@tlvEg45<(FFTtKJ@vyRpg}wT)HLxRJ+|j~PI;`FUMLnyw|(OG zXuE&S2b=l7FWY&z9nVP>#@Td2az$(2j2Q7%ZLY(2nk^Y-mS! zVF1yN?o#2dx{^jax>+Nzba_ELx~sOK9o&bPI|UYT_CN z6E*RIaN+FOG_25$Zh_!h+tFFbCEC%=6$12R!pX3i5(e$)s==|!r_E?bH%|nR`jGl& zN*J`Gn-e%|JGueap&i|#g0Vth3d5HlEg}B+UE1YgZ*50sO@wGiH&-B5gapxo=`wOCN*I*FBCUzJ5z9W)(_BeJG$I)u2sCJC$r^CUm`_Mna*tIZhEP8Ms7g{ zt~+>%KD@Jau=DzB?SsR6yZi5g>;5!hRDyj`OC;6G+x+2j5lOz6g zi}7r04kbZDt5Fv^YeT%;y0704Gq5Ha*==X3H6^nq`{3p8aAnkx+T+ZBrYEF+KMR%z z^=Bzc_01H4{AEcV)YtFcsPaingVy=C=#=i!nf)e5y*0qOjQezo8$D&Zm3lng+{}HI zx}1a_^k3L9ynCA}U$R)I?;##NA~opppkD9)O{Mfk@2^S+&C3AFd&T>HlRNO8oObF> zULX81k)TG77^bSyM`wEhvUW3rtZa{F5e@E`sHG)Zwv(wA;XX|d z9oqefg@au+fG5wU>*w&K4Z40-UIwA-CqD1HXb#~F&GN9fcKsaiD7tH4Yx#|Rt zuAk`oxhfmFexmCqx_)B)wm{cU%bE{eKPw96iae^rf$);zj|1W5VQ=mFIkE~2T|XBX zlocUFbp2eToI=;ntFoc%=hC+sTtCNFN2BZK0>ZH(iiobCE3=_J+FYQa>*tl;W^nx+ t6DD;1Typ4ENyO0gb2T@VwYfk;*Uvd57+pWBPsH=&`Tr3;qlb^;006!FE0F*I literal 3154 zcmV-Y46XA)RzVi`i(*AcNbr8tisV_Cws(_|pk8H@iDx#9GMQcN z%o0%8I5pj6yLP*)nyTu#uv!Frd^=Km77aZ?)Pj_z{(g30?zumuF}+k5V*lG_E(Un+_5|;+E_7H(FVIpmzl(+zQJ6QY>8UnNN)aUKsb>G4AOYiDh{L4IxVb@a zq0!9#d^f#&=tvPkxxwNH*bw}#q*>8W+rEGi3{I$|&=CnwVVVr^PzS4R zOv4ZbW*lx?fw8TmB@KyY#}s0sdlTg4+a-B<;YE~}rOQhZvI-=oXbNR!!AavMN{h%v zm6;R2^HgRcz9=$tqHQZOuUm>t#FR=|W1_}9|EH41{0?Vpmaj2+#43=Oyd_ka1*c5W z$MQVD85>L7Y`M;})=T)KTmPOpa4n@kuq5 zgk&@!m|7+?aL_PZGh($KaM?^kS)q4VC_Nj3Yk=N_Wb4C#iZ_mzt>XRE_F-(Mbifp_ zE*H|Y)PV^HG6gE8KIl94X#0$cOvt!e+I&XH&jM8y3Y))`( zGaCq+GrGJ!k@N=9FTkdpNEE(7BfT@eFT^clmlVJ-^n8xH0m79W(lVjF6 zR{69!<-Y7W%~a|enHEFpL+V57n=N6Q^i)&HN!T<`+mP$5fwSehcLrRSroI}jz0<7J zJqn4U(#_Y<4m#lk+WTjT_Wq2tw_Mum?`oR}UXc3Ajaky)Ge4ren?h`Ec~a*(Z%v_B z0~d<@?hPF9&V;=!5#F>WLdG*mdMXKG?Kc{T6(PYQdgDa6FHE^#?0^%ZAeTE2l5{mf zX|6*xknyGl`{|4~Wk8FRR}J{Kly}F9@{WY=^$S2CJeW*^jH(GV_}>x@{s(DrRcO!z z6S?qGB3>yMzJ}H0GGjT%HzIq42O(9^AuLQJg_9oT1CYz$PgqCrmlA{i9@i193WG9! zOhOh^HlWVi!!fm87F5WB%Fy6@1%jdj=B)mwX~(7K^t3eq6ktb6At9nlk*-N(YX0`% zKKDt|?P=Ix+~i=y6up)m?7?A=LL`DDq;&;KB+{qgi@^L!!T`9?aAdxYCzUB3c1~mJ z8@jANu5UtDXs8o)#{D`F4Wo0t23L9-3#lPJ2sW<4+qa-L1p6<{Pk%@Hum&X6@HTLI zlKqPtU8)bXWW0M@is&PvqU#$(cCT*&k=+~DuHCFnisvV_gTt-X2XJ_AtF<%0CKNu= z8S{M9GlfyV-<49voN$jS5gyYZucK;^)!1HkTO~H|Dx!?h6_@5padH$g)w}2=hTFO$ zS(kCIr~oG{DNj+MW5bDKMnERKB_uu2G**4QCJY?@SCYLiao{kM?4`R?jI(@mM>4Km z6y%Y52m6sGahdPAi;hFc^Vk_vL)o@$zyspj@4^sjY!;h zsIqk`sGAe{qFUYD6Fv#yIAb6)-qdF?RffNl*ww-fh^8L=aOcNc+dHk@54ZN(yW6$< z>8xuv6h|ZkW>%$zVLBEu4Qx{`ptZMadDOlD#@+sCE$hSS^6HL|BcorUp}v6J8^F=f zsy>=wh2nYe*vSVIj`#6nhbTq0<2hw)8dUw9#m=VF5i%m?^K{2+&XWh5jueT`&n~X% zc+TMR&ZZL+Z3do>=X}x>oHpNi)!B6DsUIc*4chsqrilmXu|3Cg%45~^La|V~?GwL8 z+x=@k*v$WZ+0Mi5cuuM?&ZZNRGb;0=20h*JoE$Q5&_B(+<^ORziuf=~%y=Tfa>P_~|DVHQxu8HD6jCKq$H@E&NK=!t??VS7eO^b4BKm zaUi^;_~Sr$dDzlERubg(dJ)=~}AOEi2DMP?c3nB=X0PP_`-tZm3}h#s1k8kI3YX&DD?sgWv4L?WS|khth^Wj1?ZipGQ~T{}LjI`!9>3vOn`x%HQBUiwZ+#9n*}MQoKstO((v z)NH(clr_67L0Ovvv`Uus_leIfvez}E<&gQhBw4RtL`KiM$l&wzJKhujfr=#9=29rn zvn8VSYfUtfMEZ4`b1eZb6YkOEN_=7|7OA5z~; z34?ZYa{^~=M>pU)w4+;8FjnYGVfgZ+CBz@UOS?Smt?lTni4g7R<_g4$kRVzxT}H6c zj&6zITielDQ6AdSRT`WXp+U5xyR?X-9o_oGa*l6AUd)c}mA6U^y73A!=!!5X+R-gF z3#zuG+bs&3)P&8vP~5cbOu^Y%KS0Or=yJ!oR`H&m%$6^Gi4;9$Ilt{ zTa15Ob0{GiT8%o=S)1eKHh%p+nE^M^)NVUVvng3N*%L2+pDUw=;2vjQG(92phgsk} zs6VR_t8b=gIrpYGxuTY zauRybf5FG_?ro}k$zq+pw|Ml3)X>X=dcFTQm2#|eROz^R89;fjc|T}!2fmk6Q@zRS zgFhyc*vJvXbXNLk1eg(mD|+9FNyUrZY2H-UZf2;J?a?fv!5tH|w4}>+GSwp7r|F?X zyC1P|u&V~}==n{HWHgpMH`Zj}0=-6s%bO~KRI95av(Is?cHndZl3p8{Iz0%tZE}>(> sgf5{=4&5q=7`lY6=7zF17ij1bI)? Date: Thu, 30 Oct 2025 18:10:57 -0400 Subject: [PATCH 4/4] test: make test serial for windows --- packages/build/tests/edge_functions/tests.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/build/tests/edge_functions/tests.js b/packages/build/tests/edge_functions/tests.js index ec84916dc8..8736f11632 100644 --- a/packages/build/tests/edge_functions/tests.js +++ b/packages/build/tests/edge_functions/tests.js @@ -174,7 +174,7 @@ for (const variant of FLAG_VARIANTS) { t.snapshot(normalizeOutput(output)) }) - test(variant.id + ' - bundles Edge Functions via runCoreSteps function', async (t) => { + test.serial(variant.id + ' - bundles Edge Functions via runCoreSteps function', async (t) => { const output = await new Fixture('./fixtures/functions_user') .withFlags({ ...variant.flags, buildSteps: ['edge_functions_bundling'], useRunCoreSteps: true }) .runWithBuild()