From 15b18b8d7342e6103482b7aeb6036604642a0ad3 Mon Sep 17 00:00:00 2001 From: Sourya Vatsyayan Date: Sun, 15 Dec 2019 11:47:59 +0530 Subject: [PATCH] Fix quality issues, add DeepSource config Signed-off-by: Sourya Vatsyayan --- .deepsource.toml | 8 ++++++++ api/bitbucket.go | 4 ++++ api/gitlab.go | 2 +- models/instance.go | 2 -- 4 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 .deepsource.toml diff --git a/.deepsource.toml b/.deepsource.toml new file mode 100644 index 0000000..59e9beb --- /dev/null +++ b/.deepsource.toml @@ -0,0 +1,8 @@ +version = 1 + +[[analyzers]] +name = "go" +enabled = true + + [analyzers.meta] + import_path = "github.com/netlify/git-gateway" diff --git a/api/bitbucket.go b/api/bitbucket.go index 2abbe4f..82bc634 100644 --- a/api/bitbucket.go +++ b/api/bitbucket.go @@ -213,6 +213,10 @@ func rewriteLinksInBitBucketResponse(resp *http.Response, endpointAPIURL, proxyA newBodyBytes, err := json.Marshal(b) + if err != nil { + return err + } + switch resp.Header.Get("Content-Encoding") { case "gzip": var compressedBody bytes.Buffer diff --git a/api/gitlab.go b/api/gitlab.go index 901eb91..ff18f8e 100644 --- a/api/gitlab.go +++ b/api/gitlab.go @@ -167,7 +167,7 @@ func rewriteGitlabLinkEntry(linkEntry, endpointAPIURL, proxyAPIURL string) strin func rewriteGitlabLinks(linkHeader, endpointAPIURL, proxyAPIURL string) string { linkEntries := strings.Split(linkHeader, ",") - finalLinkEntries := make([]string, len(linkEntries), len(linkEntries)) + finalLinkEntries := make([]string, len(linkEntries)) for i, linkEntry := range linkEntries { finalLinkEntries[i] = rewriteGitlabLinkEntry(linkEntry, endpointAPIURL, proxyAPIURL) } diff --git a/models/instance.go b/models/instance.go index 8fc2934..cb8f6c9 100644 --- a/models/instance.go +++ b/models/instance.go @@ -8,8 +8,6 @@ import ( "github.com/netlify/git-gateway/conf" ) -const baseConfigKey = "" - type Instance struct { ID string `json:"id" bson:"_id,omitempty"` // Netlify UUID