-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: insert custom folder db #15861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: insert custom folder db #15861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Closed
tobiasKaminsky
previously requested changes
Oct 29, 2025
app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadHelper.kt
Outdated
Show resolved
Hide resolved
8e7169c to
45b074e
Compare
Collaborator
Author
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15861.apk |
1db43e0 to
9c2c1d5
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
9c2c1d5 to
fa54e8a
Compare
tobiasKaminsky
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Issue
When user configured the folder for auto upload via skip existing files option, files are not being detected.
2025-10-28 11:10:24.181 7915-7963 FileSyncHelper com.nextcloud.client D walkFileTreeRandomly, reading file: /storage/emulated/0/Download/gallery_test_images/600x400.png 2025-10-28 11:10:24.181 7915-7963 FileSyncHelper com.nextcloud.client D walkFileTreeRandomly, file is not directory 2025-10-28 11:10:24.181 7915-7963 FileSyncHelper com.nextcloud.client W skipping files. SynchedFolder not exists or enabledTimestampMs not meeting condition/storage/emulated/0/Download/gallery_test_images/600x400.pngChanges
The logic is fixed for
insertCustomFolderIntoDBand tests are added.How to reproduce