Check if file is already accessible by user

[meichthys]

Currently requesting approval will share the file with the approving user. It would be helpful if the file was not shared if the file is already accessible by the approving user (i.e. the file is inside an SMB share that the user already has access to via the External Storage integration)

[julien-nc]

There already is a check done there:

approval/lib/Service/ApprovalService.php

Lines 514 to 521 in 3ca5f8f

	foreach ($rule['approvers'] as $approver) {
	if ($approver['type'] === 'user' && !$this->utilsService->userHasAccessTo($fileId, $approver['entityId'])) {
	// create user share
	if ($this->utilsService->createShare($node, IShare::TYPE_USER, $approver['entityId'], $userId, $label)) {
	$createdShares[] = $approver;
	}
	}
	}

So the file is actually not shared if the approver can access it via the main storage.
But apparently it does not work with external storages. This requires a little investigation. To be continued.

[s-rosenfeld]

There already is a check done there:

approval/lib/Service/ApprovalService.php

Lines 514 to 521 in 3ca5f8f

	foreach ($rule['approvers'] as $approver) {
	if ($approver['type'] === 'user' && !$this->utilsService->userHasAccessTo($fileId, $approver['entityId'])) {
	// create user share
	if ($this->utilsService->createShare($node, IShare::TYPE_USER, $approver['entityId'], $userId, $label)) {
	$createdShares[] = $approver;
	}
	}
	}

So the file is actually not shared if the approver can access it via the main storage.
But apparently it does not work with external storages. This requires a little investigation. To be continued.

Is there a plan for when "To be continued" can be implemented? Сorrect work with external storages (CIFS) is very necessary.

[lukasdotcom]

Hi @meichthys and @s-rosenfeld,

I can't seem to reproduce your issue or don't understand it correctly. The steps I followed to attempt to reproduce this were:

1. Create workflow for user that can be approved by admin (user not group).
2. Create external storage and make sure it has a file in it.
3. User requests approval for a file in external storage
4. Admin receives request, but no share.

If for you the approver is a group that is currently not implemented and an attempted pr for that is at #52

[meichthys]

It's been a while since i've tried this, so i'm guessing this was fixed somewhere along the line. Feel free to close this.

[lukasdotcom]

Thanks for the quick response. If it starts to happen again feel free to reply.