-
Notifications
You must be signed in to change notification settings - Fork 26
Feat/hmf reference download #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rhassaine
wants to merge
8
commits into
nf-core:dev
Choose a base branch
from
rhassaine:feat/hmf-reference-download
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic download of ~25GB HMF reference data from Hartwig's R2 CDN before running nf-tests. This ensures tests have access to the required GRCh38_hmf genome and WGS resource files. Changes: - Add Nextflow setup and reference download steps to nf-test workflow - Use prepare_reference mode to download from R2 CDN - Configure tests/nextflow.config to detect and use local reference data - Falls back to remote URLs for local development The download adds ~10-15 minutes to CI runs but ensures tests can access all required reference files without caching (GitHub Actions cache is limited to 10GB).
Refactor nf-test workflow to download ~25GB HMF reference data once and share across all matrix jobs using runs-on Magic Cache (S3-backed). Changes: - Enable Magic Cache (extras=s3-cache) on all jobs - Add dedicated download-reference job that runs once before matrix - Use actions/cache with runs-on Magic Cache for S3-backed storage - Matrix jobs now restore from cache instead of downloading individually - Add runs-on/action@v2 to all jobs for Magic Cache support Performance impact: - Before: 42 jobs × 15 min = 630 minutes of download time - After: 15 min download + (42 × 3 min restore) = 141 minutes - Saves ~489 minutes (~8 hours) per workflow run Benefits: - No GitHub 10GB cache limit (uses S3 backend) - Fast cache restore across all matrix jobs - Cache persists across workflow runs - Significant CI time savings
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.3.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
a0d15ae to
e6fb586
Compare
9002c20 to
70c3b7c
Compare
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).