Skip to content

solving #197 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ManCla wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solving #197 #198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d2ae75
deep copy partial computations stored in ast.results to avoid side-ef…
ManCla Dec 11, 2025
2ae3184
shallow copy of var before returning it
ManCla Dec 11, 2025
7b80b24
avoid in-place computations to avoid side-effects
ManCla Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions rtamt/semantics/stl/discrete_time/offline/ast_visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import math
import operator
import collections
import copy

from rtamt.syntax.ast.visitor.stl.ast_visitor import StlAstVisitor
from rtamt.semantics.enumerations.comp_oper import StlComparisonOperator
Expand All @@ -11,7 +12,7 @@ class StlDiscreteTimeOfflineAstVisitor(StlAstVisitor):

def visit(self, node, *args, **kwargs):
result = super(StlDiscreteTimeOfflineAstVisitor, self).visit(node, *args, **kwargs)
self.ast.results[node] = result
self.ast.results[node] = copy.deepcopy(result)
return result

def visitPredicate(self, node, *args, **kwargs):
Expand Down Expand Up @@ -41,7 +42,7 @@ def visitVariable(self, node, *args, **kwargs):
for v in var:
sample_return.append(operator.attrgetter(node.field)(v))
else:
sample_return = var
sample_return = list(var)
return sample_return


Expand Down Expand Up @@ -376,7 +377,7 @@ def visitTimedAlways(self, node, *args, **kwargs):
begin, end = self.time_unit_transformer(node)
sample_len = len(sample)
if sample_len <= end:
sample += [float('inf')] * (end - sample_len + 1)
sample = sample + [float('inf')] * (end - sample_len + 1)

diff = end - begin
sample_return = [min(sample[j:j+diff+1]) for j in range(begin, end+1)]
Expand All @@ -392,7 +393,7 @@ def visitTimedEventually(self, node, *args, **kwargs):
sample_len = len(sample)

if sample_len <= end:
sample += [-float('inf')] * (end - sample_len + 1)
sample = sample + [-float('inf')] * (end - sample_len + 1)

diff = end - begin
sample_return = [max(sample[j:j+diff+1]) for j in range(begin, end+1)]
Expand Down