Inlay hint shown before proc definition

[moigagoo]

Consider this code sample (from the chronos examples):

import chronos/apps/http/httpclient

proc retrievePage*(uri: string): Future[string] {.async.} =
  let httpSession = HttpSessionRef.new()

  try:
    let resp = await httpSession.fetch(parseUri(uri))
    bytesToString(resp.data)
  finally:
    await noCancel(httpSession.closeWait())

echo waitFor retrievePage(
  "https://raw.githubusercontent.com/status-im/nim-chronos/master/README.md"
)

Inlay type hint for retrievePage is shown before the proc declaration:

• VSCode:

• Helix:

1. The the hint is shown, it should be shown after the declaration.
2. in this case, it shouldn't be shown at all: the return type is already specified for this proc.

[moigagoo]

Intermediate results

The problem is that procs aren't supposed to have type hints at all. Procs with any other pragma or even async but from asyncdispatch and not Chronos do not have this issue.

Chronos's async procs appear to be transformed (and there for detected later by nimsuggest) as skLet-kind resultFuture symbols.

[moigagoo]

Intermediate results

The issue seems to be with Chronos.

Unlike asyncdispatch, Chronos's async macro generates a hardcoded ident for the returned Future: https://github.com/status-im/nim-chronos/blob/master/chronos/internal/asyncmacro.nim#L491

Asyncdispatch uses genSym: https://github.com/nim-lang/Nim/blob/devel/lib/pure/asyncmacro.nim#L301

I'm not sure why this matters, but if I replace ident with genSym and therefore force Chronos to generate a unique symbol, the type hits is correctly not shown.

Will send a PR to Chronos.

[moigagoo]

PR with the fix: status-im/nim-chronos#621