From 4112a0014376287dbc0ec8f4c54f93120c873fac Mon Sep 17 00:00:00 2001 From: Darragh Elliott Date: Wed, 24 Sep 2025 13:00:06 +0100 Subject: [PATCH] fix: remove unneeded ldflags this was discussed/raised in https://discourse.nixos.org/t/why-do-so-many-go-packages-use-s-w-in-their-ldflags-it-breaks-dontfixup-dontstrip/36843/8 --- src/lang/go/goreleaser.rs | 1 - src/main.rs | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lang/go/goreleaser.rs b/src/lang/go/goreleaser.rs index eeef4f5..4f2547c 100644 --- a/src/lang/go/goreleaser.rs +++ b/src/lang/go/goreleaser.rs @@ -23,7 +23,6 @@ struct Build { pub fn write_ldflags(out: &mut impl Write, src_dir: &Path) -> Result<()> { let (Some(raw), Some(re)) = (get_ldflags(src_dir), regex()) else { - writeln!(out, " ldflags = [ \"-s\" \"-w\" ];\n")?; return Ok(()); }; diff --git a/src/main.rs b/src/main.rs index 939ee3e..fe99bbd 100644 --- a/src/main.rs +++ b/src/main.rs @@ -151,7 +151,7 @@ async fn run() -> Result<()> { let version = match revisions.versions.remove(&rev) { Some(version) => Some(version), None => fetcher.get_version(&cl, &rev).await, - } ; + }; let version = match version { Some(Version::Latest | Version::Tag) => get_version_number(&rev).into(), Some(Version::Pypi {