Consider changes to tests

[k-doering-NOAA]

I noticed when running the ASAR tests on codespaces (ubuntu linux)
that a few times the tests halted and I was asked to provide yes/no input on whether I wanted a file overwritten. I'm not sure if this is the case on windows, too.

My understanding about testing is that it is preferable for the tests to run end-to-end without asking for developer input, so it would be good to set that up if possible!

Edit: I also noticed that the std_output.rda file was modified during the tests. It is ideal to leave the person running the test's computer unchanged. One approach to consider is writing files to a temporary directory and deleting the directory once the tests are complete: https://github.com/nmfs-ost/ghactions4r/blob/a9bf1dd9467cfb9b210f88de7f9b07750e761f8c/tests/testthat/test-use_r_workflows.R#L1-L6

[Schiano-NOAA]

I also noticed this when I run tests locally. In the function, we have a thing set up so if it's not in an interactive environment, it will continue. Do we also need to make changed to the tests themselves?

In response, to the edit, I will also check this out. Your suggestion seems simple enough to implement :)

Thanks for pointing this out Kathryn!

[kellijohnson-NOAA]

There is the R function interactive() that you can use within a function or a test to see if user input is available. Not sure if that would be helpful.

[Schiano-NOAA]

@kellijohnson-NOAA We actually do have it set for certain things, but maybe we need to add it somewhere else that's missing

[k-doering-NOAA]

Sorry I missed this question!

I also noticed this when I run tests locally. In the function, we have a thing set up so if it's not in an interactive environment, it will continue. Do we also need to make changed to the tests themselves?

A little googling tells me this is a common problem, but I think even if you are running locally, the ideal scenario is that your tests run end-to-end from a single command. I think mocking user input is common, but I've honestly never tried it, as I've never developed something that asked for user input during a function run. Maybe we could look at the usethis package for inspiration, as they definitely have functions that stop and ask for user input!

[k-doering-NOAA]

Also, there are more resources on making tests self contained in the Rpkgs book. I think the section on respecting the r landscape is also applicable, as it describes on.exit() and other approaches for not permanently altering the user's state!