From 9c5638b55952958b11862b91b2579879386bb34d Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Mon, 22 Jul 2024 09:46:47 +0200 Subject: [PATCH 1/2] set CITGM=true for undici Signed-off-by: Matteo Collina --- lib/lookup.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/lookup.json b/lib/lookup.json index 3c9da59f..e625fdd1 100644 --- a/lib/lookup.json +++ b/lib/lookup.json @@ -434,7 +434,9 @@ }, "undici": { "prefix": "v", - "maintainers": ["mcollina", "ronag"] + "envVar": { "CITGM": true }, + "maintainers": ["mcollina", "ronag"], + "comment": "skip a few tests that are too dependent on the network" }, "uuid": { "prefix": "v", From e8ff69d1a3a37ce0733051b91fdd0e73baca6a78 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Wed, 9 Jul 2025 10:46:52 +0200 Subject: [PATCH 2/2] fixup Signed-off-by: Matteo Collina --- lib/lookup.json | 4 ++-- test/reporter/test-reporter-junit.js | 12 ++++++------ test/reporter/test-reporter-tap.js | 20 ++++++++++---------- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/lookup.json b/lib/lookup.json index 08677107..10c939aa 100644 --- a/lib/lookup.json +++ b/lib/lookup.json @@ -440,9 +440,9 @@ }, "undici": { "prefix": "v", - "envVar": { "CITGM": true }, + "envVar": { "CITGM": true }, "maintainers": ["mcollina", "ronag"], - "comment": "skip a few tests that are too dependent on the network" + "comment": "skip a few tests that are too dependent on the network" }, "uuid": { "prefix": "v", diff --git a/test/reporter/test-reporter-junit.js b/test/reporter/test-reporter-junit.js index d9d5ac7b..af27e456 100644 --- a/test/reporter/test-reporter-junit.js +++ b/test/reporter/test-reporter-junit.js @@ -112,8 +112,8 @@ test('reporter.junit(): failing', (t) => { } junitReporter(logger, failingInput); - t.equal(output, failingExpected), - 'we should get the expected output when a' + ' module fails'; + (t.equal(output, failingExpected), + 'we should get the expected output when a' + ' module fails'); t.end(); }); @@ -138,8 +138,8 @@ test('reporter.junit(): write to disk', (t) => { t.plan(1); junitReporter(outputFile, passingInput); const expected = readFileSync(outputFile, 'utf8'); - t.equal(expected, passingExpected), - 'the file on disk should match the' + ' expected output'; + (t.equal(expected, passingExpected), + 'the file on disk should match the' + ' expected output'); t.end(); }); @@ -149,8 +149,8 @@ test('reporter.junit(): append to disk', (t) => { writeFileSync(outputFileAppend, appendStartFile); junitReporter(outputFileAppend, passingInput, true); const expected = readFileSync(outputFileAppend, 'utf-8'); - t.equal(expected, passingExpectedAppend), - 'the file on disk should match the' + ' expected output'; + (t.equal(expected, passingExpectedAppend), + 'the file on disk should match the' + ' expected output'); t.end(); }); diff --git a/test/reporter/test-reporter-tap.js b/test/reporter/test-reporter-tap.js index 8f033910..faad0e8f 100644 --- a/test/reporter/test-reporter-tap.js +++ b/test/reporter/test-reporter-tap.js @@ -79,8 +79,8 @@ test('reporter.tap(): failing', (t) => { } tapReporter(logger, failingInput); - t.equal(output, failingExpected), - 'we should get the expected output when a' + ' module fails'; + (t.equal(output, failingExpected), + 'we should get the expected output when a' + ' module fails'); t.end(); }); @@ -96,8 +96,8 @@ test('reporter.tap(): parser', (t) => { // `results` contains JS classes that are not considered same as the // plain objects loaded from the JSON file. const plainResults = JSON.parse(JSON.stringify(results)); - t.same(plainResults, tapParserExpected), - 'the tap parser should correctly' + ' parse the tap file'; + (t.same(plainResults, tapParserExpected), + 'the tap parser should correctly' + ' parse the tap file'); t.end(); }); str(output).pipe(p); @@ -107,8 +107,8 @@ test('reporter.tap(): write to disk', (t) => { t.plan(1); tapReporter(outputFile, passingInput); const expected = readFileSync(outputFile, 'utf8'); - t.equal(expected, passingExpected), - 'the file on disk should match the' + ' expected output'; + (t.equal(expected, passingExpected), + 'the file on disk should match the' + ' expected output'); t.end(); }); @@ -118,8 +118,8 @@ test('reporter.tap(): append to disk', (t) => { writeFileSync(outputFileAppend, appendStartFile); tapReporter(outputFileAppend, passingInput, true); const expected = readFileSync(outputFileAppend, 'utf8'); - t.equal(expected, passingExpectedAppend), - 'the file on disk should match the' + ' expected output'; + (t.equal(expected, passingExpectedAppend), + 'the file on disk should match the' + ' expected output'); t.end(); }); @@ -127,8 +127,8 @@ test('reporter.tap(): append to disk when file does not exist', (t) => { t.plan(1); tapReporter(outputFileAppendBlank, passingInput, true); const expected = readFileSync(outputFileAppendBlank, 'utf8'); - t.equal(expected, passingExpected), - 'the file on disk should match the' + ' expected output'; + (t.equal(expected, passingExpected), + 'the file on disk should match the' + ' expected output'); t.end(); });