Skip to content

Commit 258dec4

Browse files
Fix update.sh Dockerfile status reporting
Compare each generated Dockerfile with its existing copy before replacing it, so the script only announces an update when the content actually changes. Otherwise keep the original file and print an 'already up to date' message to eliminate false positives.
1 parent bd5b36d commit 258dec4

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

update.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -165,21 +165,21 @@ function update_node_version() {
165165
sed -Ei -e "s/(debian:)name-slim/\\1${variant}/" "${dockerfile}-tmp"
166166
fi
167167

168-
if diff -q "${dockerfile}-tmp" "${dockerfile}" > /dev/null; then
169-
echo "${dockerfile} is already up to date!"
170-
else
171-
if [ "${SKIP}" != true ]; then
172-
sed -Ei -e 's/^(ENV YARN_VERSION)=.*/\1='"${yarnVersion}"'/' "${dockerfile}-tmp"
173-
fi
174-
echo "${dockerfile} updated!"
168+
if [ "${SKIP}" != true ]; then
169+
sed -Ei -e 's/^(ENV YARN_VERSION)=.*/\1='"${yarnVersion}"'/' "${dockerfile}-tmp"
175170
fi
176171

177172
# Required for POSIX sed
178173
if [ -f "${dockerfile}-tmp-e" ]; then
179174
rm "${dockerfile}-tmp-e"
180175
fi
181-
182-
mv -f "${dockerfile}-tmp" "${dockerfile}"
176+
if cmp -s "${dockerfile}-tmp" "${dockerfile}"; then
177+
rm -f "${dockerfile}-tmp"
178+
info "${dockerfile} already up to date."
179+
else
180+
mv -f "${dockerfile}-tmp" "${dockerfile}"
181+
info "${dockerfile} updated."
182+
fi
183183
)
184184
}
185185

0 commit comments

Comments
 (0)