From 426d089e9708b9d5c1dd069a7d6222e531afef7c Mon Sep 17 00:00:00 2001 From: Mert Can Altin Date: Fri, 28 Mar 2025 21:54:26 +0300 Subject: [PATCH 1/2] src: collapse local var scope in loop --- src/node_dotenv.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_dotenv.cc b/src/node_dotenv.cc index 09b921fc81aa14..8ea964ba85f6d0 100644 --- a/src/node_dotenv.cc +++ b/src/node_dotenv.cc @@ -87,11 +87,11 @@ MaybeLocal Dotenv::ToObject(Environment* env) const { EscapableHandleScope scope(env->isolate()); Local result = Object::New(env->isolate()); - Local name; - Local val; auto context = env->context(); for (const auto& entry : store_) { + Local name; + Local val; if (!ToV8Value(context, entry.first).ToLocal(&name) || !ToV8Value(context, entry.second).ToLocal(&val) || result->Set(context, name, val).IsNothing()) { From 5168ceb2500b571e1ab55cf6832bb0e0078bb048 Mon Sep 17 00:00:00 2001 From: Mert Can Altin Date: Sun, 21 Dec 2025 22:13:37 +0300 Subject: [PATCH 2/2] src: collapse local var scope in loop --- src/node_dotenv.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_dotenv.cc b/src/node_dotenv.cc index e1940904d1c039..18f36e8558493f 100644 --- a/src/node_dotenv.cc +++ b/src/node_dotenv.cc @@ -67,14 +67,14 @@ std::vector Dotenv::GetDataFromArgs( } Maybe Dotenv::SetEnvironment(node::Environment* env) { + Local name; + Local val; auto context = env->context(); auto env_vars = env->env_vars(); for (const auto& entry : store_) { auto existing = env_vars->Get(entry.first.data()); if (!existing.has_value()) { - Local name; - Local val; if (!ToV8Value(context, entry.first).ToLocal(&name) || !ToV8Value(context, entry.second).ToLocal(&val)) { return Nothing();