apply suggestions

Author: bjohansebas

apps/site/components/Common/Partners/index.tsx

@@ -3,7 +3,7 @@
 import Tooltip from '@node-core/ui-components/Common/Tooltip';
 import * as PartnerLogos from '@node-core/ui-components/Icons/PartnerLogos';
 
-import { providePartners } from '#site/next-data/providers/partners';
+import providePartners from '#site/next-data/providers/partners';
 import { partners } from '#site/next.json.mjs';
 
 import type { Partner, PartnerCategory } from '#site/types';
@@ -76,8 +76,10 @@ const PartnersList: FC<PartnersListProps> = async ({
 }) => {
   const isSmall = size === 'small';
 
+  const SMALL_PARTNER_LIMIT = 6;
+
   const partners = await getPartners(
-    length ?? (isSmall ? 6 : undefined),
+    length ?? (isSmall ? SMALL_PARTNER_LIMIT : undefined),
     category,
     sort
   );

apps/site/next-data/generators/partners.mjs

@@ -0,0 +1,26 @@
+import { partners } from '#site/next.json.mjs';
+import { shuffle } from '#site/util/array';
+
+/**
+ * Provides the weighted and shuffled partners array.
+ * Results are cached using React's cache directive.
+ * @param seed - The seed for deterministic shuffling
+ * @param category - Optional category to filter partners
+ */
+const providePartners = async (seed, category) => {
+  // Create weighted array (duplicates based on weight)
+  const weightedPartners = partners.flatMap(partner => {
+    const weight = partner.weight ?? 0;
+    return Array(weight > 0 ? weight : 1).fill(partner);
+  });
+
+  // Shuffle and remove duplicates
+  const shuffled = await shuffle(weightedPartners, seed);
+  const unique = Array.from(new Set(shuffled));
+
+  return category
+    ? unique.filter(p => p.categories.includes(category))
+    : unique;
+};
+
+export default providePartners;

apps/site/next-data/providers/partners.ts

@@ -1,31 +1,5 @@
 'use cache';
 
-import { partners } from '#site/next.json.mjs';
-import { shuffle } from '#site/util/array';
+import providePartners from '#site/next-data/generators/partners.mjs';
 
-import type { Partner, PartnerCategory } from '#site/types';
-
-/**
- * Provides the weighted and shuffled partners array.
- * Results are cached using React's cache directive.
- * @param seed - The seed for deterministic shuffling
- * @param category - Optional category to filter partners
- */
-export const providePartners = async (
-  seed: number,
-  category?: PartnerCategory
-): Promise<Array<Partner>> => {
-  // Create weighted array (duplicates based on weight)
-  const weightedPartners = partners.flatMap(partner => {
-    const weight = partner.weight ?? 0;
-    return Array(weight > 0 ? weight : 1).fill(partner);
-  });
-
-  // Shuffle and remove duplicates
-  const shuffled = await shuffle(weightedPartners, seed);
-  const unique = Array.from(new Set(shuffled));
-
-  return category
-    ? unique.filter(p => p.categories.includes(category))
-    : unique;
-};
+export default providePartners;