Ready callback

[Odaeus]

In addition to the handle_setup work I found I had trouble with failing tests due to timing issues between sending a message and the consumer being ready to receive. I see that Rabbit's own tests use polling to wait on the state of the consumer GenServer.

To improve this I've added an on_ready callback: Odaeus@b6abacd

I can't open a PR yet as it's built on top of #67. Please let me know if you'd be interested in incorporating it too. I'm not fixed on on_ready as a name but handle_ready didn't sound quite appropriate.

[Odaeus]

Please let me know if you have interest in a PR for this too @nsweeting.

[nsweeting]

@Odaeus Thanks for the suggestion.

I'm wondering if you could provide a bit more context on the use case you have where an outside process is needing to interact with a consumer process?

This might also be able to get solved in another way. If you look at Rabbit.Producer - you'll see that it provides a sync_start option -

rabbit/lib/rabbit/producer.ex

Line 81 in 021b7e4

| {:sync_start, boolean()}

. What this does it ensures that the producer is fully setup within the GenServer.init/1 callback. Within the context of a supervision tree - this means the producer will block until fully setup and any processes that rely on the producer can be assured it will be ready as long as they are placed after the producer within the tree.

We could provide this option within the consumer as well. I would typically default this sync_start option to false for a consumer since in my eyes - there are less use cases where an outside process is relying on a consumer vs an outside process relying on a producer.

[Odaeus]

My main use-case so far is so that integration tests can wait for the consumer to be ready before sending a message. I had a couple of other ideas about it being useful to notify other parts of the system that the consumer was ready. One was that it would notify another part of the system that it can now register the bindings for this queue, but I can achieve the same with our beloved handle_setup 😄 if I really need it.

I normally do my best to avoid adding code only for testing but I think anything is better than polling if it can be avoided. I think your sync_start solution seems pretty good as it's perfect for using with start_supervised. Happy for me to open a PR for that?

[nsweeting]

Yeah - I think adding sync_start would be the best solution for now as it mirrors other parts of the application as well. Absolutely open to PR's! Thanks!