Our injection creation tests were failing due to self._priors.cosmology in bilby_pipe when using a PriorDict as the default_prior in InjectionCreator.
At present, only CBCPriorDict and its child classes have the cosmology attribute and related methods. For now I have pinned the bilby_pipe to v1.5.0 and have also raised this issue with bilby devs (bilby-dev/bilby#972). If they do not move the cosmology to their base PriorDict class, we have two options either keep bilby_pipe pinned to v1.5.0 or allow user to change default_prior
|
default_prior="PriorDict", |
with
CBCPriorDict as default with checks to make sure that the type of
PriorDict that is passed does have a
cosmology attribute.
I am not sure how much crucial the choice of
PriorDict is.
@tsunhopang @mcoughlin @Hen42rik any thoughts?
Our injection creation tests were failing due to
self._priors.cosmologyinbilby_pipewhen using aPriorDictas thedefault_priorinInjectionCreator.At present, only
CBCPriorDictand its child classes have thecosmologyattribute and related methods. For now I have pinned thebilby_pipeto v1.5.0 and have also raised this issue withbilbydevs (bilby-dev/bilby#972). If they do not move thecosmologyto their basePriorDictclass, we have two options either keepbilby_pipepinned to v1.5.0 or allow user to changedefault_priornmma/nmma/eos/create_injection.py
Line 343 in 0712401
with
CBCPriorDictas default with checks to make sure that the type ofPriorDictthat is passed does have acosmologyattribute.I am not sure how much crucial the choice of
PriorDictis.@tsunhopang @mcoughlin @Hen42rik any thoughts?