Miss the file `unionfind.h`

[lichengzhang1]

Hello,

when I run make, it told me this:

cc -I/path/to/headers -L/path/to/libraries -o build/name_pl -g planar/name_pl.c planar/shared/planar_base.c planar/shared/planar_input.c planar/shared/planar_automorphismgroup.c -lcprogutil
planar/name_pl.c:13:10: fatal error: unionfind.h: No such file or directory
   13 | #include "unionfind.h"
      |          ^~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:199: build/name_pl] Error 1

Where do I find unionfind.h?

Best wishes,
Licheng.

[nvcleemp]

You need this library: https://github.com/nvcleemp/cprogutil

You will also need to follow the instructions in https://github.com/nvcleemp/graphtools/blob/master/libraries.mk.template

[lichengzhang1]

@nvcleemp Thanks. I place cprogutil to the path graphtools-master, and compile the library cprogutil, and set libcprogutil.a in cprogutil/build.

Then I modified the related two links in file libraries.mk as follows.

IFLAGS = -I./cprogutil
LFLAGS = -L./cprogutil/build

But when I run make, another problems occurs. (my gcc -version is 11.3 (Ubuntu) )

mkdir -p build
cc -I./cprogutil -L./cprogutil/build -o build/name_pl -g planar/name_pl.c planar/shared/planar_base.c planar/shared/planar_input.c planar/shared/planar_automorphismgroup.c -lcprogutil
planar/name_pl.c: In function ‘get_orbits’:
planar/name_pl.c:20:25: warning: implicit declaration of function ‘unionfind_prepareNew’; did you mean ‘unionfind_prepare_new’? [-Wimplicit-function-declaration]
   20 |     UNIONFIND *orbits = unionfind_prepareNew(pg->nv);
      |                         ^~~~~~~~~~~~~~~~~~~~
      |                         unionfind_prepare_new
planar/name_pl.c:20:25: warning: initialization of ‘UNIONFIND *’ {aka ‘struct uf_struct *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
planar/name_pl.c: In function ‘name_prism_or_antiprism’:
planar/name_pl.c:226:66: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘treeSize’; did you mean ‘tree_size’?
  226 |     while(i < pg->nf && (faceOrbits->parent[i]!=i || faceOrbits->treeSize[i]!=2)) i++;
      |                                                                  ^~~~~~~~
      |                                                                  tree_size
planar/name_pl.c:228:66: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘treeSize’; did you mean ‘tree_size’?
  228 |     while(j < pg->nf && (faceOrbits->parent[j]!=j || faceOrbits->treeSize[j]==2)) j++;
      |                                                                  ^~~~~~~~
      |                                                                  tree_size
planar/name_pl.c: In function ‘name_uniform_polyhedron’:
planar/name_pl.c:273:20: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘setCount’; did you mean ‘set_count’?
  273 |     if(orbitsDual->setCount == 1){
      |                    ^~~~~~~~
      |                    set_count
planar/name_pl.c:278:27: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘setCount’; did you mean ‘set_count’?
  278 |     } else if(orbitsDual->setCount == 2){
      |                           ^~~~~~~~
      |                           set_count
planar/name_pl.c:281:58: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘treeSize’; did you mean ‘tree_size’?
  281 |             if(orbitsDual->parent[i] == i && orbitsDual->treeSize[i] < minSetSize){
      |                                                          ^~~~~~~~
      |                                                          tree_size
planar/name_pl.c:282:42: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘treeSize’; did you mean ‘tree_size’?
  282 |                 minSetSize = orbitsDual->treeSize[i];
      |                                          ^~~~~~~~
      |                                          tree_size
planar/name_pl.c: In function ‘name_two_orbit_polyhedra_with_poles’:
planar/name_pl.c:315:20: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘setCount’; did you mean ‘set_count’?
  315 |     if(orbitsDual->setCount == 1){
      |                    ^~~~~~~~
      |                    set_count
planar/name_pl.c:334:27: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘setCount’; did you mean ‘set_count’?
  334 |     } else if(orbitsDual->setCount == 2){
      |                           ^~~~~~~~
      |                           set_count
planar/name_pl.c: In function ‘name_two_orbit_polyhedra’:
planar/name_pl.c:379:58: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘treeSize’; did you mean ‘tree_size’?
  379 |         if(vertexOrbits->parent[i] == i && vertexOrbits->treeSize[i] < minOrbitSize){
      |                                                          ^~~~~~~~
      |                                                          tree_size
planar/name_pl.c:380:42: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘treeSize’; did you mean ‘tree_size’?
  380 |             minOrbitSize = vertexOrbits->treeSize[i];
      |                                          ^~~~~~~~
      |                                          tree_size
planar/name_pl.c: In function ‘name_graph’:
planar/name_pl.c:397:16: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘setCount’; did you mean ‘set_count’?
  397 |     if(orbits->setCount==1){
      |                ^~~~~~~~
      |                set_count
planar/name_pl.c:401:23: error: ‘UNIONFIND’ {aka ‘struct uf_struct’} has no member named ‘setCount’; did you mean ‘set_count’?
  401 |     } else if(orbits->setCount==2){
      |                       ^~~~~~~~
      |                       set_count
make: *** [Makefile:199: build/name_pl] Error 1

May I miss something?

[nvcleemp]

Hmm, I see that I already pushed a commit to cprogutil that I needed for another project, but I haven't updated graphtools yet. I just created a release from a previous version: https://github.com/nvcleemp/cprogutil/releases/tag/2019-11

Maybe this will work. If it doesn't work, I will have to see to setup a working environment and have a proper look, but I definitely will not be able to do this before next weekend, so I really hope that this version is sufficient, and that I did not also change something locally to the library that wasn't pushed to Github.

Maybe to explain a bit: putting this on Github was all done in my last months at Ghent University, and since switching jobs, I haven't had much time to properly clean up things. Thanks for showing interest, and I will definitely try to get things into better working order for others to use.

[lichengzhang1]

Thanks. Though, it still has a wrong. But I am still interested in many of the programs on your homepage.

mkdir -p build
cc -o build/freetree2multicode -O4 -DMAXVAL=20 conversion/freetree2multicode.c multicode/shared/multicode_base.c multicode/shared/multicode_output.c
mkdir -p build
cc -o build/multicode2signedcode -O4 conversion/multicode2signedcode.c signed/shared/signed_base.c signed/shared/signed_input.c signed/shared/signed_output.c
/usr/bin/ld: /tmp/ccSuHBHI.o:(.bss+0x0): multiple definition of `edges'; /tmp/cc0C9tYw.o:(.bss+0x20): first defined here
/usr/bin/ld: /tmp/ccAhIlFN.o:(.bss+0x0): multiple definition of `edges'; /tmp/cc0C9tYw.o:(.bss+0x20): first defined here
/usr/bin/ld: /tmp/cc4EK7qt.o:(.bss+0x0): multiple definition of `edges'; /tmp/cc0C9tYw.o:(.bss+0x20): first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:360: build/multicode2signedcode] Error 1

[nvcleemp]

OK. For this I do not need to run things myself. This does not look like a wrong version of the code, but more like a problem similar to CaGe-graph/CaGe#52: you are using a more modern version of gcc than I ever was. You will need to add the flag -fcommon to all compilation commands.

[lichengzhang1]

Nice, and now it works. I haven't looked into how to use these cute programs in detail yet, but I believe these programs will be helpful to me. Thank you for your work.

[nvcleemp]

Note that I usually try to add a little bit of explanation on how to use the program. If you want to know how you can run ./dual_pl, then you can just run ./dual_pl -h, and it will print a bit of explanation about the supported flags. Most of these programs were written because I needed them for my research, and features were added when I needed them. I tried to be consistent with adding documentation, but there might be cases of undocumented features. Feel free to keep asking questions when something isn't clear.