Skip to content

Conversation

@Anunnaki-Astronaut
Copy link

Summary

This pull request updates the RemoveSamples NZBGet extension in this repo from v1.0.1 to v1.1.0.

v1.1.0 is a feature release focused on safer sample detection, easier testing, and better control over what gets removed. It keeps conservative defaults so existing users can upgrade in place.

User-visible changes

New safety tools

  • Test Mode – dry-run mode that logs what would be removed without changing any files.
  • Block Import (Test Mode) – optional companion that reports the NZB as failed so Sonarr/Radarr/Lidarr/Prowlarr don’t import during a test run.
  • Quarantine Mode – moves samples into a _samples_quarantine subfolder instead of deleting them.
  • Quarantine Max Age – optional automatic purge of quarantine contents after N days.

Smarter detection

  • Relative Size % detection – flags a video as a sample when it is below a percentage of the largest video in the download (default: 8%).
  • Category Thresholds – per-category overrides for Relative Size %, so TV/movies/anime/etc. can be tuned separately.
  • Existing Video/Audio Size Thresholds remain (150 MB and 2 MB by default).

Additional controls

  • Protected Names/Paths – patterns for files that must never be removed (e.g. subtitles, artwork).
  • Deny Patterns – patterns for files that should always be treated as junk.
  • Optional cleanup toggles for image samples and junk extras (e.g. .txt, .url clutter).

Technical notes

  • manifest.json version is bumped to 1.1.0.
  • main.py continues to follow the NZBGet v23+ post-processing contract and uses the same exit codes (93 = SUCCESS, 94 = ERROR, 95 = NONE).
  • Detection is still based on filename patterns + size thresholds, with the new relative-size and category logic layered on top.
  • README has been updated to describe the new options and recommended defaults.

Testing

  • Automated tests pass (GitHub Actions: tests, prospector, manifest check).
  • Verified on NZBGet v23+ on both Windows and Linux, with:
    • default settings,
    • Test Mode only,
    • Test Mode + Block Import,
    • Quarantine Mode enabled.

Please let me know if you’d like any of the new options renamed, hidden by default, or documented differently for inclusion in the official extensions catalogue.

dependabot bot and others added 20 commits September 8, 2025 15:46
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ons/actions/setup-python-6

Bump actions/setup-python from 5 to 6
Removal of URL link to "Testing Guide" Wiki page. Quick test directions for debug are on the README
Updated manifest to reflect the latest version. Removed the old “Testing Guide” URL from the Debug parameter description.
- license: "GNU" -> "GPL-2.0-only" (precise SPDX)
- add "nzbgetMinVersion": "23" (manifest-based baseline)
- main.py: use NZBPP_TOTALSTATUS if NZBPP_STATUS unset (compat)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anunnaki Astronaut <anunnaki.astronaut@machinamindmeld.com>
docs: update AGENTS.md ownership and PR sanity-check guidance
Refines AGENTS.md with execution order, clear required vs optional env vars, stricter safety rules, improved test recipes, and consistent logging guidance. No code changes.
Add badges for tests, prospector, and manifest check
Refactor tests.py to improve organization and readability. Update environment variable handling and test cases for better clarity.
Updated comments and environment variable settings for clarity and consistency. Added tests for small audio and video file detection.
* feat: integrate v1.1.0 features

* New features introduced in v1.1.0

* Update tests for v1.1.0 behavior

* Refactor tests and enhance sample detection logic
@Anunnaki-Astronaut
Copy link
Author

Hi, just a quick follow up on this PR.

This updates the RemoveSamples extension to v1.1.0 with Test Mode, Quarantine Mode and safer sample detection defaults. All GitHub Actions checks are passing and I have verified it on NZBGet v23+ on both Windows and Linux.

If you have any questions or would like changes to naming, defaults or documentation so it fits better in the official extensions catalogue, I am happy to adjust.

Thanks for your time and for maintaining the NZBGet extensions.

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dnzbk dnzbk self-requested a review November 26, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant