Skip to content

Commit 96d1604

Browse files
committed
chore: fix some minor issues in the comments
Signed-off-by: spuradage <spuradage@outlook.com>
1 parent c1803e0 commit 96d1604

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

book/src/specs/kimchi.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2156,7 +2156,7 @@ The prover then follows the following steps to create the proof:
21562156
Note: unlike the original PLONK protocol,
21572157
the prover also provides evaluations of the public polynomial to help the verifier circuit.
21582158
This is why we need to absorb the commitment to the public polynomial at this point.
2159-
1. Commit to the witness columns by creating `COLUMNS` hidding commitments.
2159+
1. Commit to the witness columns by creating `COLUMNS` hiding commitments.
21602160

21612161
Note: since the witness is in evaluation form,
21622162
we can use the `commit_evaluation` optimization.
@@ -2193,7 +2193,7 @@ The prover then follows the following steps to create the proof:
21932193
* Commit to the aggregation polynomial.
21942194
* Absorb the commitment to the aggregation polynomial with the Fq-Sponge.
21952195
1. Compute the permutation aggregation polynomial $z$.
2196-
1. Commit (hidding) to the permutation aggregation polynomial $z$.
2196+
1. Commit (hiding) to the permutation aggregation polynomial $z$.
21972197
1. Absorb the permutation aggregation polynomial $z$ with the Fq-Sponge.
21982198
1. Sample $\alpha'$ with the Fq-Sponge.
21992199
1. Derive $\alpha$ from $\alpha'$ using the endomorphism (TODO: details)

kimchi/src/bench.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ impl BenchmarkCtx {
128128
}
129129
}
130130

131-
/// This function can be called before any call to a kimchi verfier,
131+
/// This function can be called before any call to a kimchi verifier,
132132
/// in which case it will serialise kimchi inputs so that they can be
133133
/// reused later for re-testing this particular prover. Used for
134134
/// serialising real mina circuits from ocaml and bindings side.

kimchi/src/prover.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ where
292292
//~ This is why we need to absorb the commitment to the public polynomial at this point.
293293
absorb_commitment(&mut fq_sponge, &public_comm);
294294

295-
//~ 1. Commit to the witness columns by creating `COLUMNS` hidding commitments.
295+
//~ 1. Commit to the witness columns by creating `COLUMNS` hiding commitments.
296296
//~
297297
//~ Note: since the witness is in evaluation form,
298298
//~ we can use the `commit_evaluation` optimization.
@@ -642,7 +642,7 @@ where
642642
internal_tracing::checkpoint!(internal_traces; z_permutation_aggregation_polynomial);
643643
let z_poly = index.perm_aggreg(&witness, &beta, &gamma, rng)?;
644644

645-
//~ 1. Commit (hidding) to the permutation aggregation polynomial $z$.
645+
//~ 1. Commit (hiding) to the permutation aggregation polynomial $z$.
646646
let z_comm = index.srs.commit(&z_poly, num_chunks, rng);
647647

648648
//~ 1. Absorb the permutation aggregation polynomial $z$ with the Fq-Sponge.

o1vm/src/pickles/lookup_prover.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use kimchi::{circuits::domains::EvaluationDomains, curve::KimchiCurve, plonk_spo
44
use mina_poseidon::FqSponge;
55
use o1_utils::ExtendedDensePolynomial;
66
use poly_commitment::{commitment::absorb_commitment, ipa::SRS, OpenProof, SRS as _};
7-
//TODO Parralelize
7+
//TODO Parallelize
88
//use rayon::prelude::*;
99
use super::lookup_columns::{ELookup, LookupChallenges, LookupEvalEnvironment};
1010
use crate::pickles::lookup_columns::*;
@@ -54,7 +54,7 @@ where
5454
};
5555

5656
// Compute the 1/beta+sum_i gamma^i value_i for each lookup term
57-
// The inversions is commputed in batch in the end
57+
// The inversions is computed in batch in the end
5858
let mut inverses: Vec<Vec<G::ScalarField>> = wires
5959
.iter()
6060
.zip(arity)
@@ -101,7 +101,7 @@ where
101101
.interpolate()
102102
};
103103
let columns_poly = columns.my_map(interpolate_col);
104-
// Commiting
104+
// Committing
105105
// TODO avoid cloning
106106
let columns_com = columns_poly
107107
.clone()
@@ -113,7 +113,7 @@ where
113113
let columns_eval_d8 = columns_poly
114114
.clone()
115115
.my_map(|poly| poly.evaluate_over_domain_by_ref(domain.d8));
116-
// abosrbing commit
116+
// absorbing commit
117117
// TODO don't absorb the wires which already have been
118118
// TODO avoid cloning
119119
columns_com

o1vm/src/pickles/lookup_verifier.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ pub fn lookup_verify<
2222
EFqSponge: Clone + FqSponge<G::BaseField, G, G::ScalarField>,
2323
EFrSponge: FrSponge<G::ScalarField>,
2424
>(
25-
// input dependant of main proto
25+
// input dependent of main proto
2626
beta_challenge: G::ScalarField,
2727
gamma_challenge: G::ScalarField,
2828
constraint: ELookup<G::ScalarField>,

poly-commitment/src/ipa.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ where
388388
self.h
389389
}
390390

391-
/// Turns a non-hiding polynomial commitment into a hidding polynomial
391+
/// Turns a non-hiding polynomial commitment into a hiding polynomial
392392
/// commitment. Transforms each given `<a, G>` into `(<a, G> + wH, w)` with
393393
/// a random `w` per commitment.
394394
fn mask(

poly-commitment/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ pub trait SRS<G: CommitmentCurve>: Clone + Sized + Sync + Send {
4545
blinders: &PolyComm<G::ScalarField>,
4646
) -> Result<BlindedCommitment<G>, CommitmentError>;
4747

48-
/// Turns a non-hiding polynomial commitment into a hidding polynomial
48+
/// Turns a non-hiding polynomial commitment into a hiding polynomial
4949
/// commitment. Transforms each given `<a, G>` into `(<a, G> + wH, w)` with
5050
/// a random `w` per commitment.
5151
/// A [BlindedCommitment] object is returned instead of a PolyComm object to

0 commit comments

Comments
 (0)