Support global image registry #367
Open
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce `.global.imageRegistry` value to allow global configuration of the image registry - split up `image.repository` into `image.registry` and `image.repository` to allow separate configuration - use `image.registry` if `.global.imageRegistry` is not set Signed-off-by: Fiete Ostkamp <F.Ostkamp@web.de>
FieteO
force-pushed
the
global-imageregistry
branch
from
ca2ec4d to
b70c902
Compare
tuunit
reviewed
Nov 12, 2025
| image: | ||
| repository: "quay.io/oauth2-proxy/oauth2-proxy" | ||
| registry: "quay.io" | ||
| repository: "oauth2-proxy/oauth2-proxy" |
Member
There was a problem hiding this comment.
this is a breaking change and would yield a bump to chart version 9.0.0
Contributor
There was a problem hiding this comment.
So also a migration guide must be added here https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/README.md#upgrading-an-existing-release-to-a-new-major-version
Author
There was a problem hiding this comment.
Thanks for the review comments! I have now added a 9.0.0 section to the upgrade information in the README.
Please feel free to suggest different wording if you like
Co-authored-by: Pierluigi Lenoci <pierluigi.lenoci@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.global.imageRegistryvalue to allow global configuration of the image registryimage.repositoryintoimage.registryandimage.repositoryto allow separate configurationimage.registryif.global.imageRegistryis not setChecklist: