Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Commit 7c9a8bc

Browse files
committed
Python3 does not have a 'long' type
Resolves #48
1 parent a99de29 commit 7c9a8bc

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ machine:
77

88
dependencies:
99
override:
10-
- pip install -r requirements/prod.txt -r requirements/dev.txt
10+
- pip install -r requirements/dev.txt
1111
- pip install tox-pyenv codecov coveralls twine
1212
- pyenv local 2.7.10 3.5.0
1313

objectrocket/util.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
"""Utility code for the objectrocket package."""
22
import functools
33
import datetime
4+
import six
5+
import sys
46

57
from six import create_bound_method
68

@@ -68,7 +70,7 @@ def sum_values(value1, value2):
6870
if value2 is None:
6971
return value1
7072

71-
number_types = (int, float, long, bool) # noqa
73+
number_types = (float, bool) + six.integer_types # noqa
7274

7375
if isinstance(value1, number_types) and isinstance(value2, number_types):
7476
return int(value1 + value2)
@@ -81,7 +83,7 @@ def sum_values(value1, value2):
8183

8284
if isinstance(value1, list):
8385
return list(set(value1 + value2))
84-
elif isinstance(value1, str) or isinstance(value1, datetime.datetime) or isinstance(value1, unicode): # noqa
86+
elif isinstance(value1, str) or isinstance(value1, datetime.datetime) or isinstance(value1, six.text_type): # noqa
8587
return value1
8688
elif isinstance(value1, dict):
8789
keys = set(value1.iterkeys()) | set(value2.iterkeys())

requirements/dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
-r prod.txt
12
Sphinx>=1.2.2
23
flake8>=2.1.0
34
mock>=1.0.1

tox.ini

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ skipsdist = True
55

66
[testenv]
77
commands = {envbindir}/py.test {posargs} {toxinidir}/tests
8-
deps = -r{toxinidir}/requirements/prod.txt
9-
-r{toxinidir}/requirements/dev.txt
8+
deps = -r{toxinidir}/requirements/dev.txt
109
passenv = PYPI_USERNAME PYPI_PASSWORD
1110
recreate = False
1211

0 commit comments

Comments
 (0)