-
Notifications
You must be signed in to change notification settings - Fork 455
feature: add an unused-libs alias #12623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff31b91 to
5ea10af
Compare
49e8456 to
848e13e
Compare
848e13e to
9f7438c
Compare
9f7438c to
00742fd
Compare
|
@nojb this is ready now |
00742fd to
1f46798
Compare
|
ping @nojb. We're preparing a release and I think users would be pleased to see this feature finally arrive. |
nojb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the lag, been really busy, as usual.
Just to confirm: if one links an executable with -linkall then none of the libraries will be "unused", right?
nojb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, a quick follow-up to the previous review (see question below). Also, I think the allow_unused_libraries field is not documented.
1f46798 to
6f15c31
Compare
Introduce an alias to detect unused libraries in libraries and executable stanzas. This stanza relies on information extracted using ocamlobjinfo to detect which modules are actually used Signed-off-by: Rudi Grinberg <me@rgrinberg.com> feature: allow_unused_libraries Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
6f15c31 to
5f76e87
Compare
Been disabled now. It will need a bit more refactoring and thought to support without unnecessary duplication. |
Introduce an alias
unused-libsthat will error out if it detects any used libraries.In the future, we could consider adding an alias per library or executable stanza if anybody wants such granularity.
Fixes #650