Skip to content

Conversation

@voodoos
Copy link
Collaborator

@voodoos voodoos commented Oct 13, 2025

Implements the behaviour described in issue #1522, fixes #1522

cc @kit-ty-kate @gr1mpatr0n

voodoos added a commit to voodoos/ocaml-lsp that referenced this pull request Oct 13, 2025
@voodoos voodoos force-pushed the more-natural-dot-merlin-fallback branch from 2a13975 to cd23389 Compare October 13, 2025 09:26
@voodoos voodoos requested a review from xvw November 6, 2025 14:41
@voodoos voodoos force-pushed the more-natural-dot-merlin-fallback branch from cd23389 to b9a40a3 Compare November 6, 2025 14:42
Copy link
Collaborator

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for the delay!)

@voodoos voodoos merged commit 8fb19ac into ocaml:master Nov 27, 2025
4 of 6 checks passed
davesnx pushed a commit to davesnx/ocaml-lsp that referenced this pull request Nov 27, 2025
…ocaml#1563)

* More natural fallback on .merlin files when no dune-project is found.

Implements the behaviour described in issue ocaml#1522, fixes ocaml#1522

* Add changelog entry for ocaml#1563

* Update CI after 5.4 release

* fmt
davesnx pushed a commit to davesnx/ocaml-lsp that referenced this pull request Nov 27, 2025
…ocaml#1563)

* More natural fallback on .merlin files when no dune-project is found.

Implements the behaviour described in issue ocaml#1522, fixes ocaml#1522

* Add changelog entry for ocaml#1563

* Update CI after 5.4 release

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why isn't --fallback-read-dot-merlin the default?

2 participants